Skip to content

fix(misconf): perform operations on attribute safely #8774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2025

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Apr 24, 2025

Description

This PR wraps operations in a safeOp function that checks that the attribute value is non-null and known before performing the operation. This is only done for operations that really need to work with a known value rather than an expression directly.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin force-pushed the tf-safe-op branch 2 times, most recently from 0c832e2 to a87ddb0 Compare April 24, 2025 16:18
@nikpivkin nikpivkin marked this pull request as ready for review April 26, 2025 04:49
@nikpivkin nikpivkin requested a review from simar7 as a code owner April 26, 2025 04:49
@simar7 simar7 added this pull request to the merge queue Apr 26, 2025
Merged via the queue into aquasecurity:main with commit 3ce7d59 Apr 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(misconf): perform operations on attribute safely
2 participants