Convert SWIMActorShell to distributed actor (#977)

* Convert SWIMActorShell to distributed actor

Resolves #973

* __secretlyKnownToBeLocal

* Change how SWIMActorShell gets initialized in ClusterShell

* Remove SWIM.Actor typealias

* Add TODOs to rename __secretlyKnownToBeLocal

* Remove usage of continuation

* Regen protobufs

* Clean up unused code

* Disable non-compiling tests

* Make confirmDead nonisolated

* Use consistent ActorPath for SWIM shell

* Fix SWIM tick not getting triggered

* Clean up and formatting

* Update SWIMSerializationTests

* Update SWIM metrics tests

* Update SWIM metrics tests

* SWIM tests

* More SWIM tests

* Fix formatting and Samples

* Minor code cleanup

* Clean up SWIM tests

* Clean up SWIM tests

* Update SWIM tests

* Fix rebase problems

* require latest cluster-membership; remove casts

* adjust for latest swim impl - it is now a struct

* validate against "main" swift cluster membership after async changes

* =swim Rename to SWIMActor

Co-authored-by: Konrad `ktoso` Malawski <[email protected]>

Author: yim-lee

Package.swift

@@ -140,7 +140,9 @@ var targets: [PackageDescription.Target] = [
 var dependencies: [Package.Dependency] = [
     .package(url: "https://github.com/apple/swift-atomics", from: "1.0.2"),
 
-    .package(url: "https://github.com/apple/swift-cluster-membership", from: "0.3.0"),
+    // .package(url: "https://github.com/apple/swift-cluster-membership", from: "0.3.0"),
+//    .package(name: "swift-cluster-membership", path: "Packages/swift-cluster-membership"), // FIXME: just work in progress
+    .package(url: "https://github.com/apple/swift-cluster-membership", branch: "main"),
 
     .package(url: "https://github.com/apple/swift-nio", from: "2.40.0"),
     .package(url: "https://github.com/apple/swift-nio-extras", from: "1.2.0"),

Protos/Cluster/SWIM/SWIM.proto

@@ -2,7 +2,7 @@
 //
 // This source file is part of the Swift Distributed Actors open source project
 //
-// Copyright (c) 2019 Apple Inc. and the Swift Distributed Actors project authors
+// Copyright (c) 2019-2022 Apple Inc. and the Swift Distributed Actors project authors
 // Licensed under Apache License v2.0
 //
 // See LICENSE.txt for license information
@@ -20,27 +20,6 @@ option swift_prefix = "_Proto";
 
 import "ActorID.proto";
 
-message SWIMRemoteMessage {
-    oneof message {
-        SWIMPing ping                 = 1;
-        SWIMPingRequest pingRequest   = 2;
-        SWIMPingResponse pingResponse = 3;
-    }
-}
-
-message SWIMPing {
-    ActorID origin            = 1;
-    SWIMGossipPayload payload = 2;
-    uint32 sequenceNumber     = 3;
-}
-
-message SWIMPingRequest {
-    ActorID target            = 1;
-    ActorID origin            = 2;
-    SWIMGossipPayload payload = 3;
-    uint32 sequenceNumber     = 4;
-}
-
 message SWIMPingResponse {
     message Ack {
         ActorID target            = 1;

Sources/DistributedActors/ActorID.swift

@@ -395,27 +395,23 @@ extension ActorID {
 }
 
 extension ActorID {
-    /// :nodoc:
     public var _isLocal: Bool {
         switch self._location {
         case .local: return true
         default: return false
         }
     }
 
-    /// :nodoc:
     public var _isRemote: Bool {
         !self._isLocal
     }
 
-    /// :nodoc:
     public var _asRemote: Self {
         var remote = self
         remote._location = .remote(remote.uniqueNode)
         return remote
     }
 
-    /// :nodoc:
     public var _asLocal: Self {
         var local = self
         local._location = .local(self.uniqueNode)

Sources/DistributedActors/ActorLogging.swift

@@ -17,10 +17,10 @@ import DistributedActorsConcurrencyHelpers
 import Foundation
 import Logging
 
-/// :nodoc:
 /// - Warning: NOT thread safe! Only use from Actors, properly synchronize access, or create multiple instances for each execution context.
-// TODO: deprecate, we should not need this explicit type
 internal final class LoggingContext {
+    // TODO: deprecate, we should not need this explicit type
+
     let identifier: String
 
     // TODO: want to eventually not have this; also move to more structured logging perhaps...