Skip to content

feat: Complete Doctrine ORM state processor example #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Nov 8, 2022

I was having problems with what was described there because it basically broke entity deletion, see api-platform/core#5107 for details.

Does this make sense? Not entirely sure if it counts as fix or feature, just let me know, I'll update branches accordingly if necessary.

It's a mix of concerns, but I also adapted the example to use property promotion because 3.0 is requiring PHP 8.1 anyways, right?

@alanpoulain
Copy link
Member

LGTM. Could you change the title since we are not really decorating a service?

@herndlm herndlm force-pushed the complete-doctrine-orm-state-processor-example branch from 33940c2 to 73ebade Compare November 8, 2022 20:20
@herndlm
Copy link
Contributor Author

herndlm commented Nov 8, 2022

adapted, I wasn't sure what you prefer here and just force-pushed because this PR is quite small anyways

@herndlm herndlm requested a review from soyuka November 9, 2022 07:58
@alanpoulain alanpoulain merged commit 26cbb7f into api-platform:3.0 Nov 9, 2022
@alanpoulain
Copy link
Member

Thanks!

@herndlm herndlm deleted the complete-doctrine-orm-state-processor-example branch November 9, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants