Skip to content

SubresourceOperations customisation DX enhancement #3466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

SubresourceOperations customisation DX enhancement #3466

wants to merge 2 commits into from

Conversation

PommeThibaudeau
Copy link
Contributor

@PommeThibaudeau PommeThibaudeau commented Mar 27, 2020

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tickets fixes #3458
License MIT
Doc PR api-platform/docs#1084

Changes the way to define serialization groups for subresources.
Changes the nomenclature to override subresource operations.

Example:

OLD NEW
api_questions_answers_get_subresource answers_get
api_questions_answers_question_get_subresource answers_question_get

@PommeThibaudeau PommeThibaudeau changed the title SubresourceOperations customisation DX enhancement [WIP] SubresourceOperations customisation DX enhancement Mar 27, 2020
@PommeThibaudeau PommeThibaudeau changed the title [WIP] SubresourceOperations customisation DX enhancement SubresourceOperations customisation DX enhancement Mar 27, 2020
@PommeThibaudeau PommeThibaudeau changed the title SubresourceOperations customisation DX enhancement [WIP] SubresourceOperations customisation DX enhancement Mar 30, 2020
Feat: Changed subresource operations nomenclature
Feat: Simplified groups configuration for subresources
Fix: Wrong ApiLoader Test
@PommeThibaudeau PommeThibaudeau changed the title [WIP] SubresourceOperations customisation DX enhancement SubresourceOperations customisation DX enhancement Mar 31, 2020
@soyuka
Copy link
Member

soyuka commented Apr 1, 2020

TODO:

  • deprecate old operation names for now (they should still work)
  • add behat test for serialization groups
  • ask @bendavies to try this 😄

@GregoireHebert
Copy link
Contributor

GregoireHebert commented Apr 4, 2020

IMO, in the Question-Answer relation, the Answer side sub-resource route should still be prefixed by the associated "parent" resource. I did not run any test, but AFAIK if you have multiple "parents" resources having the same "child" resource as sub-resource, can't you end-up with a conflict?

@soyuka soyuka mentioned this pull request Sep 22, 2020
4 tasks
Base automatically changed from master to main January 23, 2021 21:59
@vincentchalamon
Copy link
Contributor

vincentchalamon commented Jul 20, 2022

Is this PR still relevant, considering subresources are deprecated on 2.7 and removed on 3.0? @soyuka @PierreThibaudeau

@stale
Copy link

stale bot commented Nov 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 4, 2022
@stale
Copy link

stale bot commented Jan 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 3, 2023
@stale stale bot closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subresource customisation DX is poor and confusing.
4 participants