bugfix: fix introspection and re-declaration of config #1858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
commented
Apr 12, 2018
| """ | ||
| {"query":"\n query IntrospectionQuery {\n __schema {\n queryType { name }\n mutationType { name }\n subscriptionType { name }\n types {\n ...FullType\n }\n directives {\n name\n description\n locations\n args {\n ...InputValue\n }\n }\n }\n }\n\n fragment FullType on __Type {\n kind\n name\n description\n fields(includeDeprecated: true) {\n name\n description\n args {\n ...InputValue\n }\n type {\n ...TypeRef\n }\n isDeprecated\n deprecationReason\n }\n inputFields {\n ...InputValue\n }\n interfaces {\n ...TypeRef\n }\n enumValues(includeDeprecated: true) {\n name\n description\n isDeprecated\n deprecationReason\n }\n possibleTypes {\n ...TypeRef\n }\n }\n\n fragment InputValue on __InputValue {\n name\n description\n type { ...TypeRef }\n defaultValue\n }\n\n fragment TypeRef on __Type {\n kind\n name\n ofType {\n kind\n name\n ofType {\n kind\n name\n ofType {\n kind\n name\n ofType {\n kind\n name\n ofType {\n kind\n name\n ofType {\n kind\n name\n ofType {\n kind\n name\n }\n }\n }\n }\n }\n }\n }\n }\n"} | ||
| """ | ||
| And print last JSON response |
There was a problem hiding this comment.
So this is failing with:
│ {
│ "errors": [
│ {
│ "debugMessage": "Unknown kind of type: StringIterableUnionInput",
│ "message": "Internal server error",
│ "category": "internal",
│ "locations": [
│ {
│ "line": 62,
│ "column": 5
│ }
│ ],
│ "path": [
│ "__schema",
│ "types",
│ 258,
│ "inputFields",
│ 2,
│ "type",
│ "kind"
│ ]
│ },
│ {
│ "debugMessage": "Unknown kind of type: StringIterableUnionInput",
│ "message": "Internal server error",
│ "category": "internal",
│ "locations": [
│ {
│ "line": 22,
│ "column": 5
│ }
│ ],
│ "path": [
│ "__schema",
│ "types",
│ 259,
│ "kind"
│ ]
│ }
│ ],
│ "data": []
│ }
In 2.2.5 this is not failing.
Simperfit
force-pushed
the
bugfix/graphiql-schema-documentor-not-working-anymore
branch
from
fe5acf3 to
f093e07
Compare
Simperfit
changed the title
|
ping @alanpoulain for a review when you have time please. |
Simperfit
force-pushed
the
bugfix/graphiql-schema-documentor-not-working-anymore
branch
6 times, most recently
from
73ff5dc to
92ac4c9
Compare
added 2 commits
April 13, 2018 14:07
* update webonyx/graphql to last version where it introduce a $config and remove it * fix the SchemaBuilder to be able to generate the documentation
Simperfit
force-pushed
the
bugfix/graphiql-schema-documentor-not-working-anymore
branch
from
92ac4c9 to
d520833
Compare
|
Okay so this fixes the generation of the schema, but it does not fix how GraphiQL expects the schema to be. Here is a valid reproducer : Simperfit/graphql-api@bb1e22d (this patch needs to be applied on the vendor directory) |
|
I'm working on it. I've identified the issue and opened an issue in graphql-php. See webonyx/graphql-php#272. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I was trying GraphiQL, and wanted to develop an little test app with it see Simperfit/graphql-api@b521052 but I got into a little bug on the re-declaration of config, that fixed, i've seen another error with the declared type in the
SchemaBuilder.As I don't really followed the GraphQL development, I'm trying to figure out how to fix this.