Skip to content

[SPARK-40589][PS][TEST] Fix test for DataFrame.corr_with skip the pandas regression #38031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-40589][PS][TEST] Fix test for DataFrame.corr_with skip the pandas regression #38031

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f727b91
[SPARK-40589][PS][TEST] Fix test for `DataFrame.corr_with` skip the p…
itholic Sep 28, 2022
a5beb04
Add a PR link
itholic Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion python/pyspark/pandas/tests/test_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6076,7 +6076,14 @@ def test_corrwith(self):
def _test_corrwith(self, psdf, psobj):
pdf = psdf.to_pandas()
pobj = psobj.to_pandas()
for method in ["pearson", "spearman", "kendall"]:
# Regression in pandas 1.5.0 when other is Series and method is "pearson" or "spearman"
# See https://github.com/pandas-dev/pandas/issues/48826 for the reported issue,
# and https://github.com/pandas-dev/pandas/pull/46174 for the initial PR that causes.
if LooseVersion(pd.__version__) >= LooseVersion("1.5.0") and isinstance(pobj, pd.Series):
methods = ["kendall"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why also skipping pearson ? it is also changed in pandas 1.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the regression is shown in both pearson and spearman 😿

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pandas-dev/pandas#46174 FYI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about also adding this link together with https://github.com/pandas-dev/pandas/issues/48826?
since https://github.com/pandas-dev/pandas/issues/48826 is only related to spearman

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Let me add

else:
methods = ["pearson", "spearman", "kendall"]
for method in methods:
for drop in [True, False]:
p_corr = pdf.corrwith(pobj, drop=drop, method=method)
ps_corr = psdf.corrwith(psobj, drop=drop, method=method)
Expand Down