Skip to content

Commit e9a630b

Browse files
committed
Rename variable totalExecutors and clean codes
1 parent abf4860 commit e9a630b

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, actorSystem: A
4747
{
4848
// Use an atomic variable to track total number of cores in the cluster for simplicity and speed
4949
var totalCoreCount = new AtomicInteger(0)
50-
var totalExecutors = new AtomicInteger(0)
50+
var totalRegisteredExecutors = new AtomicInteger(0)
5151
val conf = scheduler.sc.conf
5252
private val timeout = AkkaUtils.askTimeout(conf)
5353
private val akkaFrameSize = AkkaUtils.maxFrameSizeBytes(conf)
@@ -94,7 +94,7 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, actorSystem: A
9494
executorAddress(executorId) = sender.path.address
9595
addressToExecutorId(sender.path.address) = executorId
9696
totalCoreCount.addAndGet(cores)
97-
totalExecutors.addAndGet(1)
97+
totalRegisteredExecutors.addAndGet(1)
9898
makeOffers()
9999
}
100100

yarn/common/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,6 @@ private[spark] class YarnClientSchedulerBackend(
151151
}
152152

153153
override def sufficientResourcesRegistered(): Boolean = {
154-
totalExecutors.get() >= totalExpectedExecutors * minRegisteredRatio
154+
totalRegisteredExecutors.get() >= totalExpectedExecutors * minRegisteredRatio
155155
}
156156
}

yarn/common/src/main/scala/org/apache/spark/scheduler/cluster/YarnClusterSchedulerBackend.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,16 @@ private[spark] class YarnClusterSchedulerBackend(
3535

3636
override def start() {
3737
super.start()
38-
var numExecutors = ApplicationMasterArguments.DEFAULT_NUMBER_EXECUTORS
38+
totalExpectedExecutors = ApplicationMasterArguments.DEFAULT_NUMBER_EXECUTORS
3939
if (System.getenv("SPARK_EXECUTOR_INSTANCES") != null) {
40-
numExecutors = IntParam.unapply(System.getenv("SPARK_EXECUTOR_INSTANCES")).getOrElse(numExecutors)
40+
totalExpectedExecutors = IntParam.unapply(System.getenv("SPARK_EXECUTOR_INSTANCES"))
41+
.getOrElse(totalExpectedExecutors)
4142
}
4243
// System property can override environment variable.
43-
numExecutors = sc.getConf.getInt("spark.executor.instances", numExecutors)
44-
totalExpectedExecutors = numExecutors
44+
totalExpectedExecutors = sc.getConf.getInt("spark.executor.instances", totalExpectedExecutors)
4545
}
4646

4747
override def sufficientResourcesRegistered(): Boolean = {
48-
totalExecutors.get() >= totalExpectedExecutors * minRegisteredRatio
48+
totalRegisteredExecutors.get() >= totalExpectedExecutors * minRegisteredRatio
4949
}
5050
}

0 commit comments

Comments
 (0)