Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Jan 8, 2020

Make sure you have checked all steps below.

Jira

https://issues.apache.org/jira/browse/PARQUET-1740

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@gszadovszky
Copy link
Contributor

The failure is not related to this change. See PARQUET-1741 for details.
I'll restart the checks after the issue is fixed.

@Fokko
Copy link
Contributor

Fokko commented Jan 8, 2020

@wangyum Can you rebase?

@gszadovszky gszadovszky merged commit 65eba55 into apache:master Jan 9, 2020
@wangyum wangyum deleted the PARQUET-1740 branch January 9, 2020 14:16
gszadovszky pushed a commit that referenced this pull request Jan 22, 2020
shangxinli pushed a commit to shangxinli/parquet-mr that referenced this pull request Mar 1, 2020
chenzhx pushed a commit to chenzhx/parquet-mr that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants