Skip to content

Commit 1ee3eaf

Browse files
author
Gabor Szadovszky
committed
PARQUET-1025: Use constant instead of creating new TypeDefinedOrder instances
1 parent 6ce1da1 commit 1ee3eaf

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

parquet-hadoop/src/main/java/org/apache/parquet/format/converter/ParquetMetadataConverter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@
8282
// TODO: Lets split it up: https://issues.apache.org/jira/browse/PARQUET-310
8383
public class ParquetMetadataConverter {
8484

85+
private static final TypeDefinedOrder TYPE_DEFINED_ORDER = new TypeDefinedOrder();
8586
public static final MetadataFilter NO_FILTER = new NoFilter();
8687
public static final MetadataFilter SKIP_ROW_GROUPS = new SkipMetadataFilter();
8788
public static final long MAX_STATS_SIZE = 4096; // limit stats to 4k
@@ -150,7 +151,7 @@ private List<ColumnOrder> getColumnOrders(MessageType schema) {
150151
// TypeDefinedOrder even if some types (e.g. INT96) have undefined column orders.
151152
for (int i = 0, n = schema.getPaths().size(); i < n; ++i) {
152153
ColumnOrder columnOrder = new ColumnOrder();
153-
columnOrder.setTYPE_ORDER(new TypeDefinedOrder());
154+
columnOrder.setTYPE_ORDER(TYPE_DEFINED_ORDER);
154155
columnOrders.add(columnOrder);
155156
}
156157
return columnOrders;

0 commit comments

Comments
 (0)