Skip to content

refactor: Remove dead code ConcurrentFutures #5939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 2, 2025

Which issue does this PR close?

Part of #5938

Rationale for this change

This issue is part of #5938, I'm going to remove dead code in our futures_utils and start tune the performance of ConcurrentTasks.

What changes are included in this PR?

Dead code removed.

Are there any user-facing changes?

No. Users should not use ConcurrentFutures from opendal.

@Xuanwo Xuanwo requested a review from WenyXu April 2, 2025 07:09
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 2, 2025
@github-actions github-actions bot added the releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" label Apr 2, 2025
@Xuanwo Xuanwo requested a review from yihong0618 April 2, 2025 08:16
Copy link
Contributor

@yihong0618 yihong0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 2, 2025
@Xuanwo
Copy link
Member Author

Xuanwo commented Apr 2, 2025

Thank you @yihong0618 and @WenyXu for the review.

@Xuanwo Xuanwo merged commit 9976c88 into main Apr 2, 2025
279 checks passed
@Xuanwo Xuanwo deleted the refactor-concurrent-tasks branch April 2, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants