[MRESOLVER-405] Get rid of component name free string literals (#330)

Use NAME constants instead.

---

https://issues.apache.org/jira/browse/MRESOLVER-405

Author: cstamas

maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnectorFactory.java

@@ -44,8 +44,9 @@
  * {@link org.eclipse.aether.spi.connector.transport.TransporterFactory transporters} and
  * {@link org.eclipse.aether.spi.connector.layout.RepositoryLayoutFactory repository layouts} for the transfers.
  */
-@Named("basic")
+@Named(BasicRepositoryConnectorFactory.NAME)
 public final class BasicRepositoryConnectorFactory implements RepositoryConnectorFactory, Service {
+    public static final String NAME = "basic";
     private TransporterProvider transporterProvider;
 
     private RepositoryLayoutProvider layoutProvider;

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/EnhancedLocalRepositoryManagerFactory.java

@@ -41,8 +41,9 @@
  * emulating physically separated artifact caches per remote repository.
  */
 @Singleton
-@Named("enhanced")
+@Named(EnhancedLocalRepositoryManagerFactory.NAME)
 public class EnhancedLocalRepositoryManagerFactory implements LocalRepositoryManagerFactory, Service {
+    public static final String NAME = "enhanced";
     private static final String CONFIG_PROP_TRACKING_FILENAME = "aether.enhancedLocalRepository.trackingFilename";
 
     private static final String DEFAULT_TRACKING_FILENAME = "_remote.repositories";

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/Maven2RepositoryLayoutFactory.java

@@ -49,8 +49,9 @@
  * Provides a Maven-2 repository layout for repositories with content type {@code "default"}.
  */
 @Singleton
-@Named("maven2")
+@Named(Maven2RepositoryLayoutFactory.NAME)
 public final class Maven2RepositoryLayoutFactory implements RepositoryLayoutFactory {
+    public static final String NAME = "maven2";
 
     public static final String CONFIG_PROP_CHECKSUMS_ALGORITHMS = "aether.checksums.algorithms";
 

maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/SimpleLocalRepositoryManagerFactory.java

@@ -36,8 +36,9 @@
  * Creates local repository managers for repository type {@code "simple"}.
  */
 @Singleton
-@Named("simple")
+@Named(SimpleLocalRepositoryManagerFactory.NAME)
 public class SimpleLocalRepositoryManagerFactory implements LocalRepositoryManagerFactory, Service {
+    public static final String NAME = "simple";
     private float priority;
 
     private LocalPathComposer localPathComposer;

maven-resolver-supplier/src/main/java/org/eclipse/aether/supplier/RepositorySystemSupplier.java

@@ -220,7 +220,9 @@ protected ChecksumAlgorithmFactorySelector getChecksumAlgorithmFactorySelector(
     protected Map<String, RepositoryLayoutFactory> getRepositoryLayoutFactories(
             ChecksumAlgorithmFactorySelector checksumAlgorithmFactorySelector) {
         HashMap<String, RepositoryLayoutFactory> result = new HashMap<>();
-        result.put("maven2", new Maven2RepositoryLayoutFactory(checksumAlgorithmFactorySelector));
+        result.put(
+                Maven2RepositoryLayoutFactory.NAME,
+                new Maven2RepositoryLayoutFactory(checksumAlgorithmFactorySelector));
         return result;
     }
 
@@ -303,8 +305,8 @@ protected Map<String, ChecksumExtractor> getChecksumExtractors() {
 
     protected Map<String, TransporterFactory> getTransporterFactories(Map<String, ChecksumExtractor> extractors) {
         HashMap<String, TransporterFactory> result = new HashMap<>();
-        result.put("file", new FileTransporterFactory());
-        result.put("http", new HttpTransporterFactory(extractors));
+        result.put(FileTransporterFactory.NAME, new FileTransporterFactory());
+        result.put(HttpTransporterFactory.NAME, new HttpTransporterFactory(extractors));
         return result;
     }
 
@@ -329,7 +331,7 @@ protected BasicRepositoryConnectorFactory getBasicRepositoryConnectorFactory(
     protected Map<String, RepositoryConnectorFactory> getRepositoryConnectorFactories(
             BasicRepositoryConnectorFactory basicRepositoryConnectorFactory) {
         HashMap<String, RepositoryConnectorFactory> result = new HashMap<>();
-        result.put("basic", basicRepositoryConnectorFactory);
+        result.put(BasicRepositoryConnectorFactory.NAME, basicRepositoryConnectorFactory);
         return result;
     }
 

maven-resolver-transport-classpath/src/main/java/org/eclipse/aether/transport/classpath/ClasspathTransporterFactory.java

@@ -36,8 +36,9 @@
  * <p>
  * <em>Note:</em> Such repositories are read-only and uploads to them are generally not supported.
  */
-@Named("classpath")
+@Named(ClasspathTransporterFactory.NAME)
 public final class ClasspathTransporterFactory implements TransporterFactory {
+    public static final String NAME = "classpath";
 
     /**
      * The key in the repository session's {@link RepositorySystemSession#getConfigProperties() configuration

maven-resolver-transport-file/src/main/java/org/eclipse/aether/transport/file/FileTransporterFactory.java

@@ -31,8 +31,9 @@
 /**
  * A transporter factory for repositories using the {@code file:} protocol.
  */
-@Named("file")
+@Named(FileTransporterFactory.NAME)
 public final class FileTransporterFactory implements TransporterFactory {
+    public static final String NAME = "file";
 
     private float priority;
 

maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporterFactory.java

@@ -37,8 +37,10 @@
  * A transporter factory for repositories using the {@code http:} or {@code https:} protocol. The provided transporters
  * support uploads to WebDAV servers and resumable downloads.
  */
-@Named("http")
+@Named(HttpTransporterFactory.NAME)
 public final class HttpTransporterFactory implements TransporterFactory {
+    public static final String NAME = "http";
+
     private static Map<String, ChecksumExtractor> getManuallyCreatedExtractors() {
         HashMap<String, ChecksumExtractor> map = new HashMap<>();
         map.put(Nexus2ChecksumExtractor.NAME, new Nexus2ChecksumExtractor());

maven-resolver-transport-wagon/src/main/java/org/eclipse/aether/transport/wagon/WagonTransporterFactory.java

@@ -36,8 +36,9 @@
  * that this factory merely serves as an adapter to the Wagon API and by itself does not provide any transport services
  * unless one or more wagon implementations are registered with the {@link WagonProvider}.
  */
-@Named("wagon")
+@Named(WagonTransporterFactory.NAME)
 public final class WagonTransporterFactory implements TransporterFactory, Service {
+    public static final String NAME = "wagon";
 
     private WagonProvider wagonProvider;