Fix [MDEP-931] Replace PrintWriter with Writer in AbstractSerializing Visitor and subclasses #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Visitor and subclasses
elharo
requested changes
May 27, 2025
| List<DependencyNode> children = node.getChildren(); | ||
| for (DependencyNode child : children) { | ||
| writer.write("\t\"" + node.toNodeString() + "\" -> \"" + child.toNodeString() + "\" ; " | ||
| + System.lineSeparator()); |
There was a problem hiding this comment.
Output should be platform independent. That is, use \n
| writer.flush(); | ||
| return true; | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Failed to write to DOT output", e); |
There was a problem hiding this comment.
UncheckedIOException but really we need to figure out how to not thrown an exception at all here, or perhaps change the method signature. Possibly we need to put everything in a StringWriter first and then write the string later.
| } | ||
| return true; | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Failed to write to DOT output", e); |
| writer.flush(); | ||
| return true; | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Failed to write GraphML node", e); |
| } | ||
| return true; | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Failed to write GraphML edge or footer", e); |
| writer.write(sb.toString()); | ||
| writer.flush(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("Failed to write JSON output", e); |
| try { | ||
| if (node.getParent() == null || node.getParent() == node) { | ||
| // dump edges on last node endVisit | ||
| writer.write("#" + System.lineSeparator()); |
| } | ||
| writer.flush(); | ||
| } else { | ||
| DependencyNode p = node.getParent(); |
| writer.write("#" + System.lineSeparator()); | ||
| for (EdgeAppender edge : edges) { | ||
| writer.write(edge.toString()); | ||
| writer.write(System.lineSeparator()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
Fixes https://issues.apache.org/jira/browse/MDEP-931
cc @elharo
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.