Fix java source and target version properties (#982)

* Fix java source and target version properties

Those properties are defined on the parent POM, inherited from maven-parent.
They are passed through to the forked maven on the command line by the failsafe plugin.
The current workaround is to remove those properties (and fix configuration for enforcer-plugin).

* Remove empty element

Author: gnodet

pom.xml

@@ -103,6 +103,12 @@ under the License.
     <version.maven-invoker-plugin>3.9.1</version.maven-invoker-plugin>
     <!-- 4.x publish -->
     <maven.site.path>${maven4x.site.path}</maven.site.path>
+
+    <maven.compiler.source />
+    <maven.compiler.target />
+    <maven.compiler.release>17</maven.compiler.release>
+    <minimalJavaBuildVersion>${maven.compiler.release}</minimalJavaBuildVersion>
+
   </properties>
 
   <dependencies>
@@ -216,6 +222,33 @@ under the License.
             </excludes>
           </configuration>
         </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-pmd-plugin</artifactId>
+          <configuration>
+            <targetJdk>${maven.compiler.release}</targetJdk>
+          </configuration>
+        </plugin>
+        <plugin>
+          <groupId>org.apache.maven.plugins</groupId>
+          <artifactId>maven-enforcer-plugin</artifactId>
+          <executions>
+            <execution>
+              <id>enforce-bytecode-version</id>
+              <goals>
+                <goal>enforce</goal>
+              </goals>
+              <configuration>
+                <rules>
+                  <enforceBytecodeVersion>
+                    <maxJdkVersion>${maven.compiler.release}</maxJdkVersion>
+                  </enforceBytecodeVersion>
+                </rules>
+                <fail>true</fail>
+              </configuration>
+            </execution>
+          </executions>
+        </plugin>
       </plugins>
     </pluginManagement>
   </build>

src/it/MCOMPILER-366/pom.xml

@@ -53,9 +53,6 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>@project.version@</version>
           <configuration>
-            <!-- TODO: remove source and target after we identified where Maven inherits those values. -->
-            <source />
-            <target />
             <release>17</release>
           </configuration>
         </plugin>

src/it/MCOMPILER-481-requires-static-included/pom.xml

@@ -41,9 +41,6 @@ under the License.
           <artifactId>maven-compiler-plugin</artifactId>
           <version>@project.version@</version>
           <configuration>
-            <!-- TODO: remove source and target after we identified where Maven inherits those values. -->
-            <source />
-            <target />
             <release>11</release>
             <!-- Older release required by the surefire plugin tested below. -->
           </configuration>

src/it/automodules-application/pom.xml

@@ -45,9 +45,6 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>@project.version@</version>
           <configuration>
-            <!-- TODO: remove source and target after we identified where Maven inherits those values. -->
-            <source />
-            <target />
             <release>17</release>
           </configuration>
         </plugin>

src/it/automodules-library/pom.xml

@@ -45,9 +45,6 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>@project.version@</version>
           <configuration>
-            <!-- TODO: remove source and target after we identified where Maven inherits those values. -->
-            <source />
-            <target />
             <release>17</release>
           </configuration>
         </plugin>

src/it/automodules-manifest/pom.xml

@@ -44,9 +44,6 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>@project.version@</version>
           <configuration>
-            <!-- TODO: remove source and target after we identified where Maven inherits those values. -->
-            <source />
-            <target />
             <release>17</release>
           </configuration>
         </plugin>

src/it/automodules-transitive-module/pom.xml

@@ -45,9 +45,6 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>@project.version@</version>
           <configuration>
-            <!-- TODO: remove source and target after we identified where Maven inherits those values. -->
-            <source />
-            <target />
             <release>17</release>
           </configuration>
         </plugin>

src/it/jdk9-exportsto/pom.xml

@@ -42,9 +42,6 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>@project.version@</version>
           <configuration>
-            <!-- TODO: remove source and target after we identified where Maven inherits those values. -->
-            <source />
-            <target />
             <release>17</release>
           </configuration>
         </plugin>

src/it/jpms_add-exports/pom.xml

@@ -36,9 +36,6 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>@project.version@</version>
           <configuration>
-            <!-- TODO: remove source and target after we identified where Maven inherits those values. -->
-            <source />
-            <target />
             <release>17</release>
             <compilerArgs>
               <arg>--add-exports</arg>

src/it/jpms_compile-main-empty-test-bar/pom.xml

@@ -45,9 +45,6 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>@project.version@</version>
           <configuration>
-            <!-- TODO: remove source and target after we identified where Maven inherits those values. -->
-            <source />
-            <target />
             <release>17</release>
           </configuration>
         </plugin>