-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
LOG4J2-3116 Google Cloud structured logging via JsonTemplate #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Volkan Yazıcı <[email protected]>
...template-json/src/test/java/org/apache/logging/log4j/layout/template/json/GcpLayoutTest.java
Outdated
Show resolved
Hide resolved
@rocketraman, I have pushed my changes to #551. I had already started working on the ticket before you had submitted your PR, hence I wanted to stick to that. Nevertheless, credit still goes to you in
I am happy with the final state of #551. If you approve, please go ahead and squash+rebase it onto |
I'm a little confused as to why you would have started work on the PR when you specifically asked me to do so on the dev mailing list when I proposed this modification, and I did that less than 3 hours later: https://lists.apache.org/thread.html/rdc25435870e47284564575b53d3b0dbf69e33ae7736f388878b89bf0%40%3Cdev.logging.apache.org%3E.
I do appreciate that, though it would have been nice to get the "commit credit" as well. Nevertheless, not a big deal.
I'll take a look shortly. |
@rocketraman, sorry for the mess. I very well see your point for commit credit. I will base #551 on top of #543. |
I appreciate that @vy. I see you've merged this in already, awesome! |
No description provided.