@@ -172,22 +172,22 @@ fn to_iceberg_binary_predicate(
172172 ( _, TransformedResult :: NotTransformed ) => return TransformedResult :: NotTransformed ,
173173 ( TransformedResult :: Column ( r) , TransformedResult :: Literal ( d) ) => ( r, d, op) ,
174174 ( TransformedResult :: Literal ( d) , TransformedResult :: Column ( r) ) => {
175- ( r, d, reserve_predicate_operator ( op) )
175+ ( r, d, reverse_predicate_operator ( op) )
176176 }
177177 _ => return TransformedResult :: NotTransformed ,
178178 } ;
179179 TransformedResult :: Predicate ( Predicate :: Binary ( BinaryExpression :: new ( op, r, d) ) )
180180}
181181
182- fn reserve_predicate_operator ( op : PredicateOperator ) -> PredicateOperator {
182+ fn reverse_predicate_operator ( op : PredicateOperator ) -> PredicateOperator {
183183 match op {
184184 PredicateOperator :: Eq => PredicateOperator :: Eq ,
185185 PredicateOperator :: NotEq => PredicateOperator :: NotEq ,
186186 PredicateOperator :: GreaterThan => PredicateOperator :: LessThan ,
187187 PredicateOperator :: GreaterThanOrEq => PredicateOperator :: LessThanOrEq ,
188188 PredicateOperator :: LessThan => PredicateOperator :: GreaterThan ,
189189 PredicateOperator :: LessThanOrEq => PredicateOperator :: GreaterThanOrEq ,
190- _ => unreachable ! ( "Support reserve {}" , op) ,
190+ _ => unreachable ! ( "Reverse {}" , op) ,
191191 }
192192}
193193
@@ -286,6 +286,9 @@ mod tests {
286286 predicate,
287287 Reference :: new( "foo" ) . is_not_in( [ Datum :: long( 5 ) , Datum :: long( 6 ) ] )
288288 ) ;
289+
290+ let predicate = convert_to_iceberg_predicate ( "not foo = 1" ) . unwrap ( ) ;
291+ assert_eq ! ( predicate, !Reference :: new( "foo" ) . equal_to( Datum :: long( 1 ) ) ) ;
289292 }
290293
291294 #[ test]
0 commit comments