Skip to content

Commit c6dc48f

Browse files
authored
infra: no need to manually install crates in CI (#1654)
## Which issue does this PR close? - Closes #. ## What changes are included in this PR? `make check-toml` and `make cargo-machete` already ensures the crates are installed. https://github.com/apache/iceberg-rust/blob/7362bbdcf72910d95ee88940f229d2eea40b3fa1/Makefile#L35-L42 https://github.com/apache/iceberg-rust/blob/7362bbdcf72910d95ee88940f229d2eea40b3fa1/Makefile#L29-L33 Resolves CI errror from `Check toml format`: ``` Run make check-toml cargo install [email protected] Updating crates.io index Downloading crates ... Downloaded taplo-cli v0.9.3 error: binary `taplo` already exists in destination Add --force to overwrite make: *** [install-taplo-cli] Error 101 Error: Process completed with exit code 2. ``` ## Are these changes tested?
1 parent 7362bbd commit c6dc48f

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,6 @@ jobs:
4949
- name: Check License Header
5050
uses: apache/skywalking-eyes/[email protected]
5151

52-
- name: Install taplo-cli
53-
uses: taiki-e/install-action@v2
54-
with:
55-
5652
- name: Check toml format
5753
run: make check-toml
5854

@@ -65,12 +61,8 @@ jobs:
6561
- name: Cargo clippy
6662
run: make check-clippy
6763

68-
- name: Install cargo-machete
69-
uses: taiki-e/install-action@v2
70-
with:
71-
tool: cargo-machete
7264
- name: Cargo Machete
73-
run: cargo machete
65+
run: make cargo-machete
7466

7567
build:
7668
runs-on: ${{ matrix.os }}

0 commit comments

Comments
 (0)