Skip to content

Commit 55d57e0

Browse files
committed
better naming
1 parent 3b45fbc commit 55d57e0

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

crates/iceberg/src/writer/file_writer/rolling_writer.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@ impl<B: FileWriterBuilder> RollingFileWriterBuilder<B> {
3838
/// # Arguments
3939
///
4040
/// * `inner_builder` - The builder for the underlying file writer
41-
/// * `target_size` - The target size in bytes before rolling over to a new file
42-
pub fn new(inner_builder: B, target_size: usize) -> Self {
41+
/// * `target_file_size` - The target size in bytes before rolling over to a new file
42+
pub fn new(inner_builder: B, target_file_size: usize) -> Self {
4343
Self {
4444
inner_builder,
45-
target_size,
45+
target_file_size,
4646
}
4747
}
4848
}
@@ -54,7 +54,7 @@ impl<B: FileWriterBuilder> FileWriterBuilder for RollingFileWriterBuilder<B> {
5454
Ok(RollingFileWriter {
5555
inner: None,
5656
inner_builder: self.inner_builder,
57-
target_size: self.target_size,
57+
target_file_size: self.target_file_size,
5858
close_handles: vec![],
5959
})
6060
}
@@ -69,7 +69,7 @@ impl<B: FileWriterBuilder> FileWriterBuilder for RollingFileWriterBuilder<B> {
6969
pub struct RollingFileWriter<B: FileWriterBuilder> {
7070
inner: Option<B::R>,
7171
inner_builder: B,
72-
target_size: usize,
72+
target_file_size: usize,
7373
close_handles: Vec<JoinHandle<Result<Vec<DataFileBuilder>>>>,
7474
}
7575

@@ -84,7 +84,7 @@ impl<B: FileWriterBuilder> RollingFileWriter<B> {
8484
///
8585
/// `true` if a new file should be started, `false` otherwise
8686
pub fn should_roll(&self, input_size: usize) -> bool {
87-
self.current_written_size() + input_size > self.target_size
87+
self.current_written_size() + input_size > self.target_file_size
8888
}
8989
}
9090

0 commit comments

Comments
 (0)