-
Notifications
You must be signed in to change notification settings - Fork 9k
HADOOP-19550. Migrate ViewFileSystemBaseTest to Junit 5 #7646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @stoty . Thank you for this patch. Can you please clean up the whitespace Checkstyle warnings?
(We can ignore the warning about making temporaryFolder
private.)
Description of PR
migrate ViewFileSystemBaseTest.java to Junit 5
This fixes the failures in the child class that have already been migrated
How was this patch tested?
Run mvn test for the affected test classes.
Note that TestViewFileSystemHdfs.testTrashRootsAfterEncryptionZoneDeletion is failing, but that one
is not run on trunk, and is probably a pre-existing issue unrelated to the Junit 5 migration issues.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?