Skip to content

Commit bdaaa3b

Browse files
committed
HDFS-14832. RBF: Add Icon for ReadOnly False. Contributed by hemanthboyina
1 parent c89d22d commit bdaaa3b

File tree

3 files changed

+35
-8
lines changed

3 files changed

+35
-8
lines changed

hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/webapps/router/federationhealth.html

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,6 +384,12 @@
384384
<!-- Mount table -->
385385
<script type="text/x-dust-template" id="tmpl-mounttable">
386386
<div class="page-header"><h1>Mount Table</h1></div>
387+
<div>
388+
<ul class="federationhealth-mounttable-legend">
389+
<li class="federationhealth-mounttable-icon federationhealth-mounttable-readonly">Read Only</li>
390+
<li class="federationhealth-mounttable-icon federationhealth-mounttable-readwrite">Read Write</li>
391+
</ul>
392+
</div>
387393
<small>
388394
<table class="table">
389395
<thead>
@@ -392,7 +398,7 @@
392398
<th>Target nameservice</th>
393399
<th>Target path</th>
394400
<th>Order</th>
395-
<th>Read only</th>
401+
<th>Mount option</th>
396402
<th>Fault tolerant</th>
397403
<th>Owner</th>
398404
<th>Group</th>
@@ -409,7 +415,7 @@
409415
<td>{nameserviceId}</td>
410416
<td>{path}</td>
411417
<td>{order}</td>
412-
<td align="center" class="mount-table-icon mount-table-read-only-{readonly}" title="{status}"/>
418+
<td align="center" class="federationhealth-mounttable-icon federationhealth-mounttable-{readonly}" title="{status}"/>
413419
<td align="center" class="mount-table-icon mount-table-fault-tolerant-{faulttolerant}" title="{ftStatus}"></td>
414420
<td>{ownerName}</td>
415421
<td>{groupName}</td>

hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/webapps/router/federationhealth.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315,10 +315,11 @@
315315
function augment_read_only(mountTable) {
316316
for (var i = 0, e = mountTable.length; i < e; ++i) {
317317
if (mountTable[i].readonly == true) {
318-
mountTable[i].readonly = "true"
319-
mountTable[i].status = "Read only"
318+
mountTable[i].readonly = "readonly"
319+
mountTable[i].status = "Read Only"
320320
} else {
321-
mountTable[i].readonly = "false"
321+
mountTable[i].readonly = "readwrite"
322+
mountTable[i].status = "Read Write"
322323
}
323324
}
324325
}

hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/webapps/static/rbf.css

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
padding-right: 5pt;
121121
}
122122

123-
.mount-table-icon:before {
123+
.federationhealth-mounttable-icon:before {
124124
font-size: 10pt;
125125
padding-right: 1pt;
126126
font-family: 'Glyphicons Halflings';
@@ -131,11 +131,31 @@
131131
-moz-osx-font-smoothing: grayscale;
132132
}
133133

134-
.mount-table-read-only-true:before {
135-
color: #5fa341;
134+
.federationhealth-mounttable-readonly:before {
135+
color: #000000;
136136
content: "\e033";
137137
}
138138

139+
.federationhealth-mounttable-readwrite:before {
140+
color: #000000;
141+
content: "\e065";
142+
}
143+
144+
.federationhealth-mounttable-legend {
145+
list-style-type: none;
146+
text-align: right;
147+
}
148+
149+
.federationhealth-mounttable-legend li {
150+
display: inline;
151+
padding: 10pt;
152+
padding-left: 10pt;
153+
}
154+
155+
.federationhealth-mounttable-legend li:before {
156+
padding-right: 5pt;
157+
}
158+
139159
.mount-table-fault-tolerant-true:before {
140160
color: #5fa341;
141161
content: "\e033";

0 commit comments

Comments
 (0)