Skip to content

Commit b57f04c

Browse files
authored
HDFS-15685. [JDK 14] TestConfiguredFailoverProxyProvider#testResolveDomainNameUsingDNS fails. (#2465)
1 parent 0b2510e commit b57f04c

File tree

1 file changed

+17
-6
lines changed

1 file changed

+17
-6
lines changed

hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestConfiguredFailoverProxyProvider.java

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import org.apache.hadoop.net.MockDomainNameResolver;
2424
import org.apache.hadoop.security.UserGroupInformation;
2525
import org.apache.hadoop.test.GenericTestUtils;
26+
import org.apache.hadoop.util.Shell;
2627
import org.apache.hadoop.util.Time;
2728
import org.junit.Before;
2829
import org.junit.BeforeClass;
@@ -292,12 +293,22 @@ private void testResolveDomainNameUsingDNS(boolean useFQDN) throws Exception {
292293
MockDomainNameResolver.FQDN_2 : "/" + MockDomainNameResolver.ADDR_2;
293294
// Check we got the proper addresses
294295
assertEquals(2, proxyResults.size());
295-
assertTrue(
296-
"nn1 wasn't returned: " + proxyResults,
297-
proxyResults.containsKey(resolvedHost1 + ":8020"));
298-
assertTrue(
299-
"nn2 wasn't returned: " + proxyResults,
300-
proxyResults.containsKey(resolvedHost2 + ":8020"));
296+
if (Shell.isJavaVersionAtLeast(14) && useFQDN) {
297+
// JDK-8225499. The string format of unresolved address has been changed.
298+
assertTrue(
299+
"nn1 wasn't returned: " + proxyResults,
300+
proxyResults.containsKey(resolvedHost1 + "/<unresolved>:8020"));
301+
assertTrue(
302+
"nn2 wasn't returned: " + proxyResults,
303+
proxyResults.containsKey(resolvedHost2 + "/<unresolved>:8020"));
304+
} else {
305+
assertTrue(
306+
"nn1 wasn't returned: " + proxyResults,
307+
proxyResults.containsKey(resolvedHost1 + ":8020"));
308+
assertTrue(
309+
"nn2 wasn't returned: " + proxyResults,
310+
proxyResults.containsKey(resolvedHost2 + ":8020"));
311+
}
301312

302313
// Check that the Namenodes were invoked
303314
assertEquals(NUM_ITERATIONS, nn1Count.get() + nn2Count.get());

0 commit comments

Comments
 (0)