Skip to content

Commit a3b500d

Browse files
authored
HDFS-16916. Improve the use of JUnit Test in DFSClient (#5404)
Co-authored-by: Zhtttylz <[email protected]> Reviewed-by: Ayush Saxena <[email protected]> Reviewed-by: Shilun Fan <[email protected]> Signed-off-by: Shilun Fan <[email protected]>
1 parent 7e48603 commit a3b500d

File tree

1 file changed

+9
-9
lines changed
  • hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/fs

1 file changed

+9
-9
lines changed

hadoop-hdfs-project/hadoop-hdfs-client/src/test/java/org/apache/hadoop/fs/TestXAttr.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
package org.apache.hadoop.fs;
2020

2121
import static org.junit.Assert.assertEquals;
22-
import static org.junit.Assert.assertFalse;
2322
import static org.junit.Assert.assertNotSame;
23+
import static org.junit.Assert.assertNotEquals;
2424

2525
import org.junit.BeforeClass;
2626
import org.junit.Test;
@@ -77,18 +77,18 @@ public void testXAttrEquals() {
7777
assertEquals(XATTR3, XATTR3);
7878
assertEquals(XATTR4, XATTR4);
7979
assertEquals(XATTR5, XATTR5);
80-
assertFalse(XATTR1.equals(XATTR2));
81-
assertFalse(XATTR2.equals(XATTR3));
82-
assertFalse(XATTR3.equals(XATTR4));
83-
assertFalse(XATTR4.equals(XATTR5));
80+
assertNotEquals(XATTR1, XATTR2);
81+
assertNotEquals(XATTR2, XATTR3);
82+
assertNotEquals(XATTR3, XATTR4);
83+
assertNotEquals(XATTR4, XATTR5);
8484
}
8585

8686
@Test
8787
public void testXAttrHashCode() {
8888
assertEquals(XATTR.hashCode(), XATTR1.hashCode());
89-
assertFalse(XATTR1.hashCode() == XATTR2.hashCode());
90-
assertFalse(XATTR2.hashCode() == XATTR3.hashCode());
91-
assertFalse(XATTR3.hashCode() == XATTR4.hashCode());
92-
assertFalse(XATTR4.hashCode() == XATTR5.hashCode());
89+
assertNotEquals(XATTR1.hashCode(), XATTR2.hashCode());
90+
assertNotEquals(XATTR2.hashCode(), XATTR3.hashCode());
91+
assertNotEquals(XATTR3.hashCode(), XATTR4.hashCode());
92+
assertNotEquals(XATTR4.hashCode(), XATTR5.hashCode());
9393
}
9494
}

0 commit comments

Comments
 (0)