HDFS-16724. Modify patch based on comments

zengqiang.xu · zengqiang.xu · commit a0b33ae191e7 · 2022-08-13T00:32:31.000+08:00
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NoLocationException.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/NoLocationException.java
@@ -27,11 +27,7 @@ public class NoLocationException extends IOException {
 
   private static final long serialVersionUID = 1L;
 
-  public NoLocationException(String path, String className) {
-    super("Cannot find locations for " + path + " in " + className);
-  }
-
-  public NoLocationException(String message) {
-    super(message);
+  public NoLocationException(String path, Class<?> t) {
+    super("Cannot find locations for " + path + " in " + t.getSimpleName());
   }
 }
diff --git a/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java b/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
@@ -1731,7 +1731,7 @@ protected List<RemoteLocation> getLocationsForPath(String path,
       final PathLocation location =
           this.subclusterResolver.getDestinationForPath(path);
       if (location == null) {
-        throw new NoLocationException(path, this.subclusterResolver.getClass().getSimpleName());
+        throw new NoLocationException(path, this.subclusterResolver.getClass());
       }
 
       // We may block some write operations

Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,7 @@ public class NoLocationException extends IOException {`
`27`	`27`
`28`	`28`	`private static final long serialVersionUID = 1L;`
`29`	`29`
`30`		`- public NoLocationException(String path, String className) {`
`31`		`- super("Cannot find locations for " + path + " in " + className);`
`32`		`- }`
`33`		`-`
`34`		`- public NoLocationException(String message) {`
`35`		`- super(message);`
	`30`	`+ public NoLocationException(String path, Class<?> t) {`
	`31`	`+ super("Cannot find locations for " + path + " in " + t.getSimpleName());`
`36`	`32`	`}`
`37`	`33`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1731,7 +1731,7 @@ protected List<RemoteLocation> getLocationsForPath(String path,`
`1731`	`1731`	`final PathLocation location =`
`1732`	`1732`	`this.subclusterResolver.getDestinationForPath(path);`
`1733`	`1733`	`if (location == null) {`
`1734`		`- throw new NoLocationException(path, this.subclusterResolver.getClass().getSimpleName());`
	`1734`	`+ throw new NoLocationException(path, this.subclusterResolver.getClass());`
`1735`	`1735`	`}`
`1736`	`1736`
`1737`	`1737`	`// We may block some write operations`