YARN-11252. Fix CheckStyle.

Author: slfan1989

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/impl/pb/DeleteReservationHomeSubClusterRequestPBImpl.java

@@ -110,13 +110,13 @@ public ReservationId getReservationId() {
   }
 
   @Override
-  public void setReservationId(ReservationId ReservationId) {
+  public void setReservationId(ReservationId reservationId) {
     maybeInitBuilder();
-    if (ReservationId == null) {
+    if (reservationId == null) {
       builder.clearReservationId();
       return;
     }
-    builder.setReservationId(convertToProtoFormat(ReservationId));
+    builder.setReservationId(convertToProtoFormat(reservationId));
   }
 
   private ReservationId convertFromProtoFormat(ReservationIdProto appId) {
@@ -126,5 +126,4 @@ private ReservationId convertFromProtoFormat(ReservationIdProto appId) {
   private ReservationIdProto convertToProtoFormat(ReservationId appId) {
     return ((ReservationIdPBImpl) appId).getProto();
   }
-
 }

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/records/impl/pb/UpdateReservationHomeSubClusterRequestPBImpl.java

@@ -110,13 +110,13 @@ public ReservationHomeSubCluster getReservationHomeSubCluster() {
 
   @Override
   public void setReservationHomeSubCluster(
-      ReservationHomeSubCluster ReservationInfo) {
+      ReservationHomeSubCluster reservationInfo) {
     maybeInitBuilder();
-    if (ReservationInfo == null) {
+    if (reservationInfo == null) {
       builder.clearAppSubclusterMap();
       return;
     }
-    builder.setAppSubclusterMap(convertToProtoFormat(ReservationInfo));
+    builder.setAppSubclusterMap(convertToProtoFormat(reservationInfo));
   }
 
   private ReservationHomeSubCluster convertFromProtoFormat(
@@ -128,5 +128,4 @@ private ReservationHomeSubClusterProto convertToProtoFormat(
       ReservationHomeSubCluster sc) {
     return ((ReservationHomeSubClusterPBImpl) sc).getProto();
   }
-
 }

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/policies/router/BaseRouterPoliciesTest.java

@@ -214,7 +214,6 @@ public void testUpdateReservation() throws YarnException {
 
     // get all activeSubClusters
     Map<SubClusterId, SubClusterInfo> activeSubClusters = getActiveSubclusters();
-    activeSubClusters.remove(chosen);
 
     // Update ReservationHomeSubCluster
     List<SubClusterId> subClusterIds = new ArrayList<>(activeSubClusters.keySet());
@@ -230,8 +229,8 @@ public void testUpdateReservation() throws YarnException {
                  null, false, false, 1, null, null, false);
 
     applicationSubmissionContext.setReservationID(resReq.getReservationId());
-    SubClusterId chosen3 = ((FederationRouterPolicy) getPolicy())
-        .getHomeSubcluster(applicationSubmissionContext,new ArrayList<>());
+    SubClusterId chosen3 = routerPolicy.getHomeSubcluster(
+        applicationSubmissionContext, new ArrayList<>());
 
     Assert.assertEquals(chosen2, chosen3);
   }

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/policies/router/TestRejectRouterPolicy.java

@@ -58,6 +58,12 @@ public void testNullQueueRouting() throws YarnException {
     localPolicy.getHomeSubcluster(applicationSubmissionContext, null);
   }
 
+  @Override
+  @Test(expected = FederationPolicyException.class)
+  public void testFollowReservation() throws YarnException {
+    super.testFollowReservation();
+  }
+
   @Override
   @Test(expected = FederationPolicyException.class)
   public void testUpdateReservation() throws YarnException {