Skip to content

Commit 4b50981

Browse files
committed
HDDS-1709. TestScmSafeNode is flaky.
Contributed by Elek, Marton.
1 parent 049bb42 commit 4b50981

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestScmSafeMode.java

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,25 +17,22 @@
1717
*/
1818
package org.apache.hadoop.ozone.om;
1919

20-
import java.io.IOException;
21-
import java.util.Collections;
22-
import java.util.List;
23-
import java.util.Map;
2420
import org.apache.commons.lang3.RandomStringUtils;
2521
import org.apache.hadoop.hdds.HddsConfigKeys;
2622
import org.apache.hadoop.hdds.conf.OzoneConfiguration;
2723
import org.apache.hadoop.hdds.protocol.proto.HddsProtos;
2824
import org.apache.hadoop.hdds.protocol.proto.HddsProtos.LifeCycleEvent;
2925
import org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationFactor;
3026
import org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationType;
31-
import org.apache.hadoop.hdds.scm.container.SCMContainerManager;
32-
import org.apache.hadoop.hdds.scm.safemode.SCMSafeModeManager;
3327
import org.apache.hadoop.hdds.scm.container.ContainerInfo;
28+
import org.apache.hadoop.hdds.scm.container.SCMContainerManager;
3429
import org.apache.hadoop.hdds.scm.events.SCMEvents;
3530
import org.apache.hadoop.hdds.scm.exceptions.SCMException;
3631
import org.apache.hadoop.hdds.scm.protocolPB.StorageContainerLocationProtocolClientSideTranslatorPB;
32+
import org.apache.hadoop.hdds.scm.safemode.SCMSafeModeManager;
3733
import org.apache.hadoop.hdds.scm.server.SCMClientProtocolServer;
3834
import org.apache.hadoop.hdds.scm.server.StorageContainerManager;
35+
import org.apache.hadoop.hdds.server.events.EventQueue;
3936
import org.apache.hadoop.ozone.HddsDatanodeService;
4037
import org.apache.hadoop.ozone.MiniOzoneCluster;
4138
import org.apache.hadoop.ozone.OzoneConfigKeys;
@@ -56,6 +53,11 @@
5653
import org.slf4j.Logger;
5754
import org.slf4j.LoggerFactory;
5855

56+
import java.io.IOException;
57+
import java.util.Collections;
58+
import java.util.List;
59+
import java.util.Map;
60+
5961
import static org.junit.Assert.assertFalse;
6062
import static org.junit.Assert.assertTrue;
6163
import static org.junit.Assert.fail;
@@ -278,6 +280,10 @@ public void testSCMSafeMode() throws Exception {
278280
GenericTestUtils
279281
.waitFor(() -> scm.getCurrentContainerThreshold() == 1.0, 100, 20000);
280282

283+
EventQueue eventQueue =
284+
(EventQueue) cluster.getStorageContainerManager().getEventQueue();
285+
eventQueue.processAll(5000L);
286+
281287
double safeModeCutoff = conf
282288
.getDouble(HddsConfigKeys.HDDS_SCM_SAFEMODE_THRESHOLD_PCT,
283289
HddsConfigKeys.HDDS_SCM_SAFEMODE_THRESHOLD_PCT_DEFAULT);

0 commit comments

Comments
 (0)