Skip to content

Commit 42c8f61

Browse files
authored
HADOOP-18441. Remove hadoop custom ServicesResourceTransformer (#4850). Contributed by PJ Fanning.
Signed-off-by: Ayush Saxena <[email protected]>
1 parent c664f95 commit 42c8f61

File tree

6 files changed

+3
-266
lines changed

6 files changed

+3
-266
lines changed

hadoop-client-modules/hadoop-client-api/pom.xml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -98,13 +98,6 @@
9898
<createSourcesJar>true</createSourcesJar>
9999
<shadeSourcesContent>true</shadeSourcesContent>
100100
</configuration>
101-
<dependencies>
102-
<dependency>
103-
<groupId>org.apache.hadoop</groupId>
104-
<artifactId>hadoop-maven-plugins</artifactId>
105-
<version>${project.version}</version>
106-
</dependency>
107-
</dependencies>
108101
<executions>
109102
<execution>
110103
<phase>package</phase>
@@ -254,8 +247,7 @@
254247
</relocation>
255248
</relocations>
256249
<transformers>
257-
<!-- Needed until MSHADE-182 -->
258-
<transformer implementation="org.apache.hadoop.maven.plugin.shade.resource.ServicesResourceTransformer"/>
250+
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
259251
<transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer"/>
260252
<transformer implementation="org.apache.maven.plugins.shade.resource.DontIncludeResourceTransformer">
261253
<resource>NOTICE.txt</resource>

hadoop-client-modules/hadoop-client-minicluster/pom.xml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -671,13 +671,6 @@
671671
<plugin>
672672
<groupId>org.apache.maven.plugins</groupId>
673673
<artifactId>maven-shade-plugin</artifactId>
674-
<dependencies>
675-
<dependency>
676-
<groupId>org.apache.hadoop</groupId>
677-
<artifactId>hadoop-maven-plugins</artifactId>
678-
<version>${project.version}</version>
679-
</dependency>
680-
</dependencies>
681674
<executions>
682675
<execution>
683676
<phase>package</phase>
@@ -1052,8 +1045,7 @@
10521045
</relocation>
10531046
</relocations>
10541047
<transformers>
1055-
<!-- Needed until MSHADE-182 -->
1056-
<transformer implementation="org.apache.hadoop.maven.plugin.shade.resource.ServicesResourceTransformer"/>
1048+
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
10571049
<transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer"/>
10581050
<transformer implementation="org.apache.maven.plugins.shade.resource.DontIncludeResourceTransformer">
10591051
<resources>

hadoop-client-modules/hadoop-client-runtime/pom.xml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,6 @@
128128
<plugin>
129129
<groupId>org.apache.maven.plugins</groupId>
130130
<artifactId>maven-shade-plugin</artifactId>
131-
<dependencies>
132-
<dependency>
133-
<groupId>org.apache.hadoop</groupId>
134-
<artifactId>hadoop-maven-plugins</artifactId>
135-
<version>${project.version}</version>
136-
</dependency>
137-
</dependencies>
138131
<executions>
139132
<execution>
140133
<phase>package</phase>
@@ -397,8 +390,7 @@
397390
-->
398391
</relocations>
399392
<transformers>
400-
<!-- Needed until MSHADE-182 -->
401-
<transformer implementation="org.apache.hadoop.maven.plugin.shade.resource.ServicesResourceTransformer"/>
393+
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
402394
<transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer"/>
403395
<transformer implementation="org.apache.maven.plugins.shade.resource.DontIncludeResourceTransformer">
404396
<resources>

hadoop-maven-plugins/pom.xml

Lines changed: 0 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -68,56 +68,6 @@
6868
<groupId>com.fasterxml.jackson.core</groupId>
6969
<artifactId>jackson-databind</artifactId>
7070
</dependency>
71-
<dependency>
72-
<groupId>org.apache.maven.plugins</groupId>
73-
<artifactId>maven-shade-plugin</artifactId>
74-
<version>${maven-shade-plugin.version}</version>
75-
<scope>provided</scope>
76-
<exclusions>
77-
<!-- shade conflicts with itself and other maven internals so we simply
78-
exclude shade's (older) copies of the dependencies -->
79-
<exclusion>
80-
<groupId>org.apache.maven</groupId>
81-
<artifactId>maven-artifact</artifactId>
82-
</exclusion>
83-
<exclusion>
84-
<groupId>org.apache.maven</groupId>
85-
<artifactId>maven-compat</artifactId>
86-
</exclusion>
87-
<exclusion>
88-
<groupId>org.apache.maven</groupId>
89-
<artifactId>maven-core</artifactId>
90-
</exclusion>
91-
<exclusion>
92-
<groupId>org.apache.maven</groupId>
93-
<artifactId>maven-model</artifactId>
94-
</exclusion>
95-
<exclusion>
96-
<groupId>org.apache.maven</groupId>
97-
<artifactId>maven-plugin-api</artifactId>
98-
</exclusion>
99-
<exclusion>
100-
<groupId>org.vafer</groupId>
101-
<artifactId>jdependency</artifactId>
102-
</exclusion>
103-
<exclusion>
104-
<groupId>org.sonatype.sisu</groupId>
105-
<artifactId>sisu-inject-plexus</artifactId>
106-
</exclusion>
107-
<exclusion>
108-
<groupId>org.apache.maven.plugin-tools</groupId>
109-
<artifactId>maven-plugin-annotations</artifactId>
110-
</exclusion>
111-
<exclusion>
112-
<groupId>org.sonatype.aether</groupId>
113-
<artifactId>aether-api</artifactId>
114-
</exclusion>
115-
<exclusion>
116-
<groupId>org.sonatype.aether</groupId>
117-
<artifactId>aether-util</artifactId>
118-
</exclusion>
119-
</exclusions>
120-
</dependency>
12171
<dependency>
12272
<groupId>org.apache.hadoop.thirdparty</groupId>
12373
<artifactId>hadoop-shaded-guava</artifactId>

hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/shade/resource/ServicesResourceTransformer.java

Lines changed: 0 additions & 166 deletions
This file was deleted.

hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/shade/resource/package-info.java

Lines changed: 0 additions & 23 deletions
This file was deleted.

0 commit comments

Comments
 (0)