add tests to demonstrate JDK22+ Thread behaviour

Author: stoty

hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/concurrent/TestSubjectPropagation.java

@@ -19,27 +19,30 @@
 package org.apache.hadoop.util.concurrent;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
 
 import java.util.concurrent.Callable;
 
 import javax.security.auth.Subject;
 
 import org.apache.hadoop.security.authentication.util.SubjectUtil;
 import org.apache.hadoop.util.Daemon;
+import org.apache.hadoop.util.Shell;
 import org.junit.jupiter.api.Test;
 
 public class TestSubjectPropagation {
 
   private Subject childSubject = null;
 
   @Test
-  public void testWork() {
+  public void testSubjectInheritingThreadOverride() {
     Subject parentSubject = new Subject();
     childSubject = null;
 
     SubjectUtil.callAs(parentSubject, new Callable<Void>() {
       public Void call() throws InterruptedException {
         SubjectInheritingThread t = new SubjectInheritingThread() {
+          @Override
           public void work() {
             childSubject = SubjectUtil.current();
           }
@@ -54,7 +57,7 @@ public void work() {
   }
 
   @Test
-  public void testRunnable() {
+  public void testSubjectInheritingThreadRunnable() {
     Subject parentSubject = new Subject();
     childSubject = null;
 
@@ -78,13 +81,14 @@ public void run() {
   }
 
   @Test
-  public void testDeamonWork() {
+  public void testDaemonOverride() {
     Subject parentSubject = new Subject();
     childSubject = null;
 
     SubjectUtil.callAs(parentSubject, new Callable<Void>() {
       public Void call() throws InterruptedException {
         Daemon t = new Daemon() {
+          @Override
           public void work() {
             childSubject = SubjectUtil.current();
           }
@@ -122,4 +126,83 @@ public void run() {
     assertEquals(parentSubject, childSubject);
   }
 
+  @Test
+  public void testThreadOverride() {
+    Subject parentSubject = new Subject();
+    childSubject = null;
+
+    SubjectUtil.callAs(parentSubject, new Callable<Void>() {
+      public Void call() throws InterruptedException {
+
+        Thread t = new Thread() {
+          @Override
+          public void run() {
+            childSubject = SubjectUtil.current();
+          }
+        };
+        t.start();
+        t.join(1000);
+        return (Void) null;
+      }
+    });
+
+    boolean securityManagerEnabled = true;
+    try {
+      SecurityManager sm = System.getSecurityManager();
+      System.setSecurityManager(sm);
+    } catch (UnsupportedOperationException e) {
+      // JDK24+ always throws this
+      securityManagerEnabled = false;
+    } catch (Throwable t) {
+      // don't care
+    }
+
+    if (Shell.isJavaVersionAtLeast(22) && !securityManagerEnabled) {
+      // This is the behaviour that breaks Hadoop authorization
+      assertNull(childSubject);
+    } else {
+      assertEquals(parentSubject, childSubject);
+    }
+  }
+
+  @Test
+  public void testThreadRunnable() {
+    Subject parentSubject = new Subject();
+    childSubject = null;
+
+    SubjectUtil.callAs(parentSubject, new Callable<Void>() {
+      public Void call() throws InterruptedException {
+        Runnable r = new Runnable() {
+          @Override
+          public void run() {
+            childSubject = SubjectUtil.current();
+          }
+        };
+
+        Thread t = new Thread(r);
+        t.start();
+        t.join(1000);
+        return (Void) null;
+      }
+    });
+
+    boolean securityManagerEnabled = true;
+    try {
+      SecurityManager sm = System.getSecurityManager();
+      System.setSecurityManager(sm);
+    } catch (UnsupportedOperationException e) {
+      // JDK24+ always throws this
+      securityManagerEnabled = false;
+    } catch (Throwable t) {
+      // don't care
+    }
+
+    if (Shell.isJavaVersionAtLeast(22) && !securityManagerEnabled) {
+      // This is the behaviour that breaks Hadoop authorization
+      assertNull(childSubject);
+    } else {
+      assertEquals(parentSubject, childSubject);
+    }
+  }
+
 }