Skip to content

Consolidate grails-data-graphql and grails-data-neo4j into grails-data-mapping #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2,180 commits into from
Mar 8, 2025

Conversation

jamesfredley
Copy link
Contributor

Neither of these have been updated for Grails 7, so they will not be built for now, but are being brought over so they can be updated at a later time.

git remote add neo4j [email protected]:grails/grails-data-neo4j.git
git fetch neo4j 
git merge -s ours --no-commit --allow-unrelated-histories neo4j/8.2.x
git read-tree --prefix=neo4j/ -u neo4j/8.2.x
git commit -m "Imported grails-data-neo4j"

git remote add graphql [email protected]:grails/grails-data-graphql.git
git fetch graphql
git merge -s ours --no-commit --allow-unrelated-histories graphql/4.0.x
git read-tree --prefix=graphql/ -u graphql/4.0.x
git commit -m "Imported grails-data-graphql"

puneetbehl and others added 30 commits May 18, 2022 15:43
Configure environment variables for accessing Gradle Remote cache
* Update groovy monorepo to v3.0.11

* Improvements around CompileStatic

In Apache Groovy 3.0.11, the compiler is more strict towards type conversion.

Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Puneet Behl <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configure GitHub Workflow
…o-2.x

Update dependency com.github.fakemongo:fongo to v2.1.1
renovate bot and others added 15 commits February 2, 2024 17:21
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Update CI pipeline

* Fix compilation problem
* Add test to check many-to-many queries are generated properly

* Generate correct match strings for Neo4j relationships
* migrate to develocity build cache connect

* typo and add config

---------

Co-authored-by: Emma Richardson <[email protected]>
@jamesfredley jamesfredley self-assigned this Mar 7, 2025
@jamesfredley jamesfredley added this to the grails:7.0.0-M4 milestone Mar 7, 2025
@jamesfredley
Copy link
Contributor Author

The failure is occurring in the 9.0.x branch, so will fix it on another PR first, then rerun this one.

@jamesfredley jamesfredley requested a review from jdaugherty March 7, 2025 20:26
Copy link
Contributor

@jdaugherty jdaugherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @matrei needs to look over this as well.

Only minor nitpicks:

  1. Should we update the README.md files to reflect the projects haven't been ported?
  2. Should we prefix them with a "grails-data-" or something similar so we can identify these as gorm implementations?

@matrei
Copy link
Contributor

matrei commented Mar 8, 2025

LGTM. grails-data-* directory names could make sense.

@jamesfredley
Copy link
Contributor Author

I was 50/50 between with and without grails-data-. Since both of you mentioned it I will update. I will also update the readmes before merging.

@jamesfredley jamesfredley merged commit 5da65ad into 9.0.x Mar 8, 2025
10 checks passed
@jamesfredley jamesfredley deleted the consolidate-neo4j-graphql branch March 8, 2025 16:15
@github-project-automation github-project-automation bot moved this to Done in Grails 7 Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate grails-data-graphql and grails-data-neo4j into grails-data-mapping