Skip to content

Merge when ready should use pull request description for merge commit body (or make it configurable) #18002

@rluvaton

Description

@rluvaton

Merge when ready use the commits as the merge commit body, however a lot of times (at least for me) the commits message in pull request are not

it should instead use the pull request description as the commit message body as it contains more information

Here’s a cleaner, more polished issue title and body you can use:

Currently, the Merge when ready feature uses the individual commit messages as the merge commit body.
However, in many cases — especially for larger pull requests — the individual commits contain incremental or low-signal changes (e.g. "fix typo", "rename param", "cleanup"), which makes the resulting merge commit body noisy and uninformative.

Instead, it would be more useful if Merge when ready used the pull request description as the merge commit body, since we have a template for pull request and they usually provide clearer info

Examples of merge commits that would benefit from pull request description

5472e5d

* clean up duplicate information in FileOpener trait
* remove unused struct
* remove more
* rename paramter
* more renames
* minimize diff
* fix renames
* fix renames
* more fixes

Another example:
f8e988f

* Chore: Migrate avg from comet to datafusion-spark and add a few tests.
* CI Fix: Apply cargo format.
* CI Fix: Add coerce types function.
* Add group by tests to the suite.
* Add doc highlighting differences with Spark.
* CI assertion error fixes and improved docs.

---------
Co-authored-by: sriram <[email protected]>

Documentation on how to change it from apache/infrastructure-asfyaml:
https://github.com/apache/infrastructure-asfyaml#merge-buttons

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions