Skip to content

Commit a5bfedd

Browse files
committed
Update tests so they pass after arrow upgrade
1 parent dc177d2 commit a5bfedd

File tree

1 file changed

+1
-16
lines changed

1 file changed

+1
-16
lines changed

datafusion/substrait/tests/cases/roundtrip_logical_plan.rs

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -716,29 +716,14 @@ async fn all_type_literal() -> Result<()> {
716716
date32_col = arrow_cast('2020-01-01', 'Date32') AND
717717
binary_col = arrow_cast('binary', 'Binary') AND
718718
large_binary_col = arrow_cast('large_binary', 'LargeBinary') AND
719-
view_binary_col = arrow_cast(arrow_cast('binary_view', 'Binary'), 'BinaryView') AND
719+
view_binary_col = arrow_cast('binary_view', 'BinaryView') AND
720720
utf8_col = arrow_cast('utf8', 'Utf8') AND
721721
large_utf8_col = arrow_cast('large_utf8', 'LargeUtf8') AND
722722
view_utf8_col = arrow_cast('utf8_view', 'Utf8View');",
723723
)
724724
.await
725725
}
726726

727-
/// Arrow-cast does not currently handle direct casting from utf8 to binaryView.
728-
#[tokio::test]
729-
async fn binaryview_type_literal_needs_casting_fix() -> Result<()> {
730-
let err = roundtrip_all_types(
731-
"select * from data where
732-
view_binary_col = arrow_cast('binary_view', 'BinaryView');",
733-
)
734-
.await;
735-
736-
assert!(
737-
matches!(err, Err(e) if e.to_string().contains("Unsupported CAST from Utf8 to BinaryView"))
738-
);
739-
Ok(())
740-
}
741-
742727
#[tokio::test]
743728
async fn roundtrip_literal_list() -> Result<()> {
744729
roundtrip("SELECT [[1,2,3], [], NULL, [NULL]] FROM data").await

0 commit comments

Comments
 (0)