Skip to content

update parse STRICT tables #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2023
Merged

update parse STRICT tables #903

merged 3 commits into from
Jun 23, 2023

Conversation

parkma99
Copy link
Contributor

close #898

What changes are included in this PR?

add STRICT keyword.
add some to enable parse STRICT table.
add one test about STRICT table.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @parkma99

@coveralls
Copy link

coveralls commented Jun 23, 2023

Pull Request Test Coverage Report for Build 5357623493

  • 14 of 16 (87.5%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 86.92%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/helpers/stmt_create_table.rs 5 6 83.33%
src/parser.rs 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 78.25%
src/parser.rs 1 82.92%
Totals Coverage Status
Change from base Build 5347302069: 0.001%
Covered Lines: 15058
Relevant Lines: 17324

💛 - Coveralls

@alamb alamb merged commit 04c9fba into apache:main Jun 23, 2023
serprex pushed a commit to serprex/sqlparser-rs that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sqlite] SqliteDialect is unable to parse STRICT tables
3 participants