Skip to content

Use smarter macros to avoid duplication in keywords.rs #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2019
Merged

Use smarter macros to avoid duplication in keywords.rs #63

merged 1 commit into from
May 11, 2019

Conversation

nickolay
Copy link
Contributor

@nickolay nickolay commented May 4, 2019

We have two identical lists of keywords in keywords.rs: keyword!() and ALL_KEYWORDS. With slightly more complex macros we can avoid this duplication.

@nickolay nickolay requested a review from andygrove May 4, 2019 14:03
@coveralls
Copy link

coveralls commented May 4, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 171

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.176%
Totals Coverage Status
Change from base Build 168: 0.0%
Covered Lines: 2862
Relevant Lines: 3283
💛 - Coveralls

@nickolay nickolay merged commit 908082d into apache:master May 11, 2019
@nickolay nickolay deleted the pr/refactor-keywords branch May 11, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickolay @coveralls @andygrove