Skip to content

Commit 45c25ef

Browse files
committed
do not run string to date test on spark-3.2
1 parent 7708a24 commit 45c25ef

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

spark/src/test/scala/org/apache/comet/CometCastSuite.scala

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -571,6 +571,7 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
571571
}
572572

573573
test("cast StringType to DateType") {
574+
assume(CometSparkSessionExtensions.isSpark33Plus)
574575
val validDates = Seq(
575576
"262142-01-01",
576577
"262142-01-01 ",
@@ -611,14 +612,11 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
611612
"2020-mar-20",
612613
"not_a_date",
613614
"T2")
614-
castTest((validDates ++ invalidDates).toDF("a"), DataTypes.DateType)
615-
// TODO: fuzz test
616-
// castTest(gen.generateStrings(dataSize, datePattern, 8).toDF("a"), DataTypes.DateType)
617-
}
618615

619616
// due to limitations of NaiveDate we only support years between 262143 BC and 262142 AD"
620617
val unsupportedYearPattern: Regex = "^\\s*[0-9]{5,}".r
621-
val fuzzDates = generateStrings(datePattern, 8)
618+
val fuzzDates = gen
619+
.generateStrings(dataSize, datePattern, 8)
622620
.filterNot(str => unsupportedYearPattern.findFirstMatchIn(str).isDefined)
623621
castTest((validDates ++ invalidDates ++ fuzzDates).toDF("a"), DataTypes.DateType)
624622
}

0 commit comments

Comments
 (0)