Skip to content

Commit 45d8832

Browse files
committed
ARROW-293: [C++] Implement Arrow IO interfaces for operating system files
I started with the code I put together previously for Feather and conformed it to the `arrow::io` API. There's a bunch of Windows compatibility stuff; I left this until we add CI for Windows and can sort this out. We should also refactor the memory mapped file interfaces to be based on this common code (see ARROW-294). Author: Wes McKinney <[email protected]> Closes #146 from wesm/ARROW-293 and squashes the following commits: a2653b7 [Wes McKinney] cpplint d56ef06 [Wes McKinney] Test the rest of ReadableFile methods 43126ca [Wes McKinney] Drafting OS file IO implementations based on Feather implementation. Work on test suite
1 parent 32fd692 commit 45d8832

File tree

14 files changed

+1080
-13
lines changed

14 files changed

+1080
-13
lines changed

cpp/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,7 @@ if (UNIX)
570570
add_custom_target(lint ${BUILD_SUPPORT_DIR}/cpplint.py
571571
--verbose=2
572572
--linelength=90
573-
--filter=-whitespace/comments,-readability/todo,-build/header_guard,-build/c++11,-runtime/references
573+
--filter=-whitespace/comments,-readability/todo,-build/header_guard,-build/c++11,-runtime/references,-build/include_order
574574
${FILTERED_LINT_FILES})
575575
endif (UNIX)
576576

cpp/src/arrow/io/CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ set(ARROW_IO_TEST_LINK_LIBS
3838
${ARROW_IO_PRIVATE_LINK_LIBS})
3939

4040
set(ARROW_IO_SRCS
41+
file.cc
4142
memory.cc
4243
)
4344

@@ -103,12 +104,17 @@ if (APPLE)
103104
INSTALL_NAME_DIR "@rpath")
104105
endif()
105106

107+
ADD_ARROW_TEST(io-file-test)
108+
ARROW_TEST_LINK_LIBRARIES(io-file-test
109+
${ARROW_IO_TEST_LINK_LIBS})
110+
106111
ADD_ARROW_TEST(io-memory-test)
107112
ARROW_TEST_LINK_LIBRARIES(io-memory-test
108113
${ARROW_IO_TEST_LINK_LIBS})
109114

110115
# Headers: top level
111116
install(FILES
117+
file.h
112118
hdfs.h
113119
interfaces.h
114120
memory.h

0 commit comments

Comments
 (0)