-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
enhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelogparquetChanges to the parquet crateChanges to the parquet crateparquet-variantparquet-variant* cratesparquet-variant* crates
Description
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We have two functions that are inverses of each other that are confusingly named;
cast_to_variantwhich casts arrow arrays to variantvariant_to_arrowwhich casts variants to arrow arrays
Further adding to the confusion is that we have modules named arrow_to_variant which doesn't contain the casting kernel
Describe the solution you'd like
I would like the names to be consistent
Describe alternatives you've considered
I propose changing the names of the casting functions to be more explicit:
cast_arrow_to_variantcast_variant_to_arrow
And leaving the conversion code in the modules arrow_to_variant and variant_to_arrow
Additional context
Came up with conversation with @scovich on
Metadata
Metadata
Assignees
Labels
enhancementAny new improvement worthy of a entry in the changelogAny new improvement worthy of a entry in the changelogparquetChanges to the parquet crateChanges to the parquet crateparquet-variantparquet-variant* cratesparquet-variant* crates