Skip to content

Add tests cases for multiple executors in chart #44424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

romsharon98
Copy link
Contributor

@romsharon98 romsharon98 commented Nov 27, 2024

related: #43606
adding examples to all files changed in the related PR to check validity for multiple executors and fix the errors.
with the tests, I found a problem in chart/templates/rbac/pod-launcher-rolebinding.yaml so I fix it here too.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Nov 27, 2024
@romsharon98 romsharon98 self-assigned this Nov 27, 2024
@romsharon98 romsharon98 added this to the Airflow Helm Chart 1.16.0 milestone Dec 16, 2024
@eladkal eladkal requested a review from amoghrajesh December 16, 2024 17:59
@eladkal eladkal force-pushed the add-tests-with-new-executors branch from 819a12e to 55cfc01 Compare January 4, 2025 16:28
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 thanks.
One qn

@romsharon98 romsharon98 force-pushed the add-tests-with-new-executors branch from 55cfc01 to beec000 Compare January 6, 2025 13:22
@romsharon98 romsharon98 merged commit 972714e into apache:main Jan 7, 2025
59 checks passed
HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
* add examples for tests with multiple executors

* fix pod-launcher-rolebinding to handel multiple executors

* fix hpa tests

* remove deprecated test
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* add examples for tests with multiple executors

* fix pod-launcher-rolebinding to handel multiple executors

* fix hpa tests

* remove deprecated test
Copy link

@Atharv625 Atharv625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the Helm template bug — this unblocks Helm upgrades for many users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants