-
Notifications
You must be signed in to change notification settings - Fork 14.9k
Add tests cases for multiple executors in chart #44424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
romsharon98
merged 4 commits into
apache:main
from
romsharon98:add-tests-with-new-executors
Jan 7, 2025
Merged
Add tests cases for multiple executors in chart #44424
romsharon98
merged 4 commits into
apache:main
from
romsharon98:add-tests-with-new-executors
Jan 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
819a12e
to
55cfc01
Compare
amoghrajesh
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1 thanks.
One qn
55cfc01
to
beec000
Compare
eladkal
approved these changes
Jan 6, 2025
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
* add examples for tests with multiple executors * fix pod-launcher-rolebinding to handel multiple executors * fix hpa tests * remove deprecated test
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* add examples for tests with multiple executors * fix pod-launcher-rolebinding to handel multiple executors * fix hpa tests * remove deprecated test
62 tasks
Atharv625
reviewed
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on the Helm template bug — this unblocks Helm upgrades for many users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #43606
adding examples to all files changed in the related PR to check validity for multiple executors and fix the errors.
with the tests, I found a problem in
chart/templates/rbac/pod-launcher-rolebinding.yaml
so I fix it here too.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.