Skip to content

Commit b9beb09

Browse files
umutsoysalansyspre-commit-ci[bot]pyansys-ci-botRobPasMue
authored
feat: surface body unit test fix (#2118)
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <[email protected]> Co-authored-by: Roberto Pastor Muela <[email protected]>
1 parent 3c3cf7f commit b9beb09

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

doc/changelog.d/2118.added.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Surface body unit test fix

src/ansys/geometry/core/_grpc/_services/v0/repair_tools.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -620,6 +620,7 @@ def serialize_body(body):
620620
},
621621
"master_id": body.master_id,
622622
"parent_id": body.parent_id,
623+
"is_surface": body.is_surface,
623624
}
624625

625626
def serialize_entity_identifier(entity):

src/ansys/geometry/core/tools/problem_areas.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ def serialize_body(body):
111111
},
112112
"master_id": body.master_id,
113113
"parent_id": body.parent_id,
114+
"is_surface": body.is_surface,
114115
}
115116

116117
def serialize_entity_identifier(entity):

tests/integration/test_repair_tools.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -403,10 +403,9 @@ def test_find_and_fix_missing_faces(modeler: Modeler):
403403
for face in missing_faces:
404404
face.fix()
405405

406-
# TODO : Add surface body check from backend. Issue is being tracked in #2031.
407-
# assert not design.bodies[0].is_surface
408-
# for comp in design.components:
409-
# assert not comp.bodies[0].is_surface
406+
assert not design.bodies[0].is_surface
407+
for comp in design.components:
408+
assert not comp.bodies[0].is_surface
410409

411410

412411
def test_find_and_fix_missing_faces_angle_distance(modeler: Modeler):
@@ -458,8 +457,7 @@ def test_find_and_stitch_and_missing_faces(modeler: Modeler):
458457
for i in stitch_faces:
459458
i.fix()
460459
assert len(design.bodies) == 1
461-
# TODO : Add surface body check from backend. Issue is being tracked in #2031.
462-
# assert design.bodies[0].is_surface
460+
assert design.bodies[0].is_surface
463461
missing_faces = modeler.repair_tools.find_missing_faces(design.bodies)
464462
for face in missing_faces:
465463
face.fix()

0 commit comments

Comments
 (0)