Skip to content

Improvements in builds for .NET nanoFramework #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

josesimoes
Copy link
Contributor

Changes addressing comments in #837 after merging and having the 1st full build on AppVeyor.

  • Update PS1 to update version in nuspec files.
  • Rename Invoke-Build-NanoNugets to match PS version analysis used in AppVeyor.
  • Simplification of output messages reporting progress of .NET nanoFrameowrk projects processing.
  • Fix nuspec versions.
  • Remove whitespace in nuspec description.
  • Fix Directory.Build.props to point .NET nanoFramewok output directory to specific Artifacts sub-directory.

@josesimoes josesimoes force-pushed the improvements-nanoframework-build branch 2 times, most recently from dac1c7b to 7e577ef Compare May 10, 2021 09:07
- Update PS1 to update version in nuspec files.
- Rename Invoke-Build-NanoNugets to match PS version analysis used in AppVeyor.
- Simplification of output messages reporting progress of .NET nanoFrameowrk projects processing.
- Fix nuspec versions.
- Remove whitespace in nuspec description.
- Fix Directory.Build.props to point .NET nanoFramewok output directory to specific Artifacts sub-directory.
@josesimoes josesimoes force-pushed the improvements-nanoframework-build branch from 7e577ef to ef15f50 Compare May 10, 2021 09:30
<title>Units.NET Frequency - nanoFramework</title>
<authors>Andreas Gullberg Larsen, nanoFramework project contributors</authors>
<owners>UnitsNet</owners>
<license type="expression">MIT</license>
<projectUrl>https://github.com/angularsen/UnitsNet</projectUrl>
<requireLicenseAcceptance>false</requireLicenseAcceptance>
<description>Adds Frequency units for Units.NET on .NET nanoFramework.&#10; For .NET or .NET Core, use UnitsNet instead.</description>
<description>Adds Frequency units for Units.NET on .NET nanoFramework.&#10;For .NET or .NET Core, use UnitsNet instead.</description>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this &#10; character intentional? Why not a regular space? I pushed a commit removing it, but let me know if that was a mistake.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a line break in XML.
It shows the description as:

Adds Frequency units for Units.NET on .NET nanoFramework.
For .NET or .NET Core, use UnitsNet instead.

Instead of:

Adds Frequency units for Units.NET on .NET nanoFramework. For .NET or .NET Core, use UnitsNet instead.

Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Merging it to see how it plays out on appveyor.

@angularsen
Copy link
Owner

Checked the PR build, looks good to me.

image

image

image

@angularsen angularsen merged commit df2692b into angularsen:master May 10, 2021
@josesimoes
Copy link
Contributor Author

All right!! 👏🏻 😄

@josesimoes
Copy link
Contributor Author

@angularsen will you be uploading all the new nuget packages for nanoframework? Just checking...

@josesimoes josesimoes deleted the improvements-nanoframework-build branch May 10, 2021 19:05
@angularsen
Copy link
Owner

angularsen commented May 10, 2021

@josesimoes I'm currently waiting for master branch build to complete. I expect it to push 4.90.0 of the temperature nuget.
If I am not mistaken, the build script currently only packs Temperature nuget and not the others?

@angularsen
Copy link
Owner

It completed 10 minutes ago. Nuget is out.
https://www.nuget.org/packages/UnitsNet.nanoFramework.Temperature/

@josesimoes
Copy link
Contributor Author

josesimoes commented May 10, 2021

@josesimoes I'm currently waiting for master branch build to complete. I expect it to push 4.90.0 of the temperature nuget.
If I am not mistaken, the build script currently only packs Temperature nuget and not the others?

It's supposed to generate all those identified by @Ellerbach being used in .NET Core IoT.

My bad! It's missing the others... I'll fix that ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants