-
Notifications
You must be signed in to change notification settings - Fork 393
Conversion between pressure measurement references #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e conversion - by gratestas
… incorrect vaules and failed test results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, love the tests!
I got some feedback for you to consider.
UnitsNet.Serialization.JsonNet/UnitsNet.Serialization.JsonNet.csproj
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
+ Coverage 58.51% 58.56% +0.05%
==========================================
Files 170 171 +1
Lines 38375 38430 +55
==========================================
+ Hits 22454 22507 +53
- Misses 15921 15923 +2
Continue to review full report at Codecov.
|
Yes, not necessarily word by word, just describe the parameters and what
they will be used for.
… |
I added a ctor overload for a third parameter: the atmospheric pressure referenced for conversion between Absolute, Gauge, and Vacuum. Otherwise, |
I'll try to get a look at this tomorrow.
|
@angularsen, based on your comment in #724, would it be best to move the code in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor things, but it's looking good!
…ution to meet code style requirements." This reverts commit ffa1d05.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is getting ready, just a few more minor things.
Awesome, great work! Nuget is on the way out. |
Based off the proposal in #422, and building upon the work of @gratestas in Units by @YektaMirkan.
Adds a wrapper class called
ReferencePressure
and an enumPressureReference
to provide a reference for pressure measurements.Utilizes two constructors for implementation:
The single-parameter constructor sets the
PressureReference
parameter to a default ofPressureReference.Absolute
As @gratestas mentioned in #422, implementation uses the example:
Extended the work of @gratestas with further testing, and handling of exceptions regarding pressures less than absolute zero.