Separate WindowsRuntimeComponent into its own source code and code generators #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh God it feels good to remove this stuff ❤️ |
For now, we want to build WRC, business as usual. If we find that WRC keeps adding pain even with separate code and scripts, we can further consider removing it from continuous integration.
This was referenced Feb 13, 2019
tmilnthorp
approved these changes
Feb 13, 2019
|
Sweeet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #597
/WindowsRuntimeComponentfolder#if WINDOWS_UWPsectionsbuild-with-wrc.bat.jsonfiles are still sharedThis should be a refactor and not introduce any functional changes, except for maybe some minor things I found in WRC regarding the recently added
Quantitytypes that are not very well supported in WRC anyway. I wouldn't consider it a breaking change.I think this should remove the majority of pain associated with WRC:
We can always branch out and remove WRC entirely if we find it still adds pain, but I don't think that will be necessary anytime soon unless we do a major overhaul of the
.jsonfile approach.