Test pr 423 #424
Closed
Test pr 423 #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the serialization test project: If in debug configuration, use the UnitsNet.Serialization project reference. If in release configuration, use the latest version of UnitsNet.Serialization as well as UnitsNet in nuget.
Change UnitsNet code (see Mass.g.cs) which will break serialization library in nuget. Update JsonConverter to support the said change.
|
Ahhh. Appveyor calls generate-code.bat :( |
Manually change _value to _valueRenamed in the custom codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: THIS PR IS MADE JUST TO TEST #423
In summary:
2a. While in Visual Studio and Debug Mode, the tests still passed which means that the updated JSON code will support the updated UnitsNet code.