Add More Flow Units #361
Add More Flow Units #361
Conversation
Fixes #360
UnitsNet/UnitDefinitions/Flow.json
Outdated
| "Localization": [ | ||
| { | ||
| "Culture": "en-US", | ||
| "Abbreviations": [ "galUS/s" ] |
There was a problem hiding this comment.
In volume we've written gal (U.S.). Then gal (U.S.)/s would be consistent here, but that seems awkward. @angularsen what do you think?
There was a problem hiding this comment.
We actually display US Gallons as gal (US).
Takes less space and seems to be clear enough.
Also less awkward when used in Flow gal (US)/s
We also display US Survey Feet as ft (US) ... ft (US)/s
There was a problem hiding this comment.
It is awkward, but at least it is consistent. I think it's fine.
UnitsNet/UnitDefinitions/Flow.json
Outdated
| "Localization": [ | ||
| { | ||
| "Culture": "en-US", | ||
| "Abbreviations": [ "galUS/h" ] |
There was a problem hiding this comment.
Same comment regarding gal (U.S.) here
UnitsNet/UnitDefinitions/Flow.json
Outdated
| "Localization": [ | ||
| { | ||
| "Culture": "en-US", | ||
| "Abbreviations": [ "cf/hr" ] |
There was a problem hiding this comment.
The official abbreviation of cubic foot is ft³ and cf isn't listed on Wikipedia. I would suggest to change this to ft³/h and perhaps add this as an alternative
| "Localization": [ | ||
| { | ||
| "Culture": "en-US", | ||
| "Abbreviations": [ "ft³/h", "cf/hr" ] |
There was a problem hiding this comment.
Is cf/hr used? Having it here means you expect to parse it.
If we keep this, should the same be added for cubic yards per hour below?
There was a problem hiding this comment.
cf/hr was already there before this PR so I didn't remove it. I suggest we put the task of removing it in the wishlist for breaking changes.
There was a problem hiding this comment.
Ah I missed that. Good point, if you could add it to the wishlist that would be good!
|
Alrighty, this should be good to go then |
|
Nuget 3.87 on the way out |
|
Thank you! 💯 |
Fixes #360