New Quantity: SpecificEntropy

[gratestas]

No description provided.

[0xferit]

I reverted bf96253, which is an irrelevant commit, and fixed conflicts. There is another issue with SpecificEntropy conversions and @gratestas is working on it.

[0xferit]

Everything looks fine except consistency in scientific notation. AFAIK we prefer using lower-case e without zero padding.

[angularsen]

XmlDocRemarks is not supported, move this into XmlDoc.

[angularsen]

I got 2.390057e-4 at: https://www.gordonengland.co.uk/conversion/specific_heat.htm
And 0.0002390057361377 at https://www.translatorscafe.com/unit-converter/en/specific-heat-capacity/1-6/joule%2Fkilogram%2FK-calorie%20(IT)%2Fgram%2F%C2%B0C/

[0xferit]

Just asking to prevent any potential misunderstanding: Do you suggest to change the 2.39005e-4 with what you got, 2.390057e-4, in SpecificEntropyTests.cs?

[angularsen]

I would use the must accurate value found in a reference source 0.0002390057361377 in the test.
Then these JSON functions must also be updated as they seem wrong, but I don't know if they should be represented as some calculation or as the same constant.

[0xferit]

I couldn't spot the error in JSON function :/

Fixed values in tests.

[0xferit]

BTW, https://www.translatorscafe.com/unit-converter/en/specific-heat-capacity/1-6/joule%2Fkilogram%2FK-calorie%20(IT)%2Fgram%2F%C2%B0C/ gives 0.000238845896627 not 0.0002390057361377.

I updated values in the test as 0.0002390057.

I would like to leave this p.r. to you and @gratestas to finalize before merging, as I'm a bit confused.

[angularsen]

Careful, you linked to the IT calorie unit. It is slightly different than Th calories. I think we should add both and name them explicitly to avoid ambiguity.

[0xferit]

Oh, yeah, but I copied your link :)

I agree that we should fix this ambiguity in the entire library soon.

[angularsen]

Sorry, my bad. The JSON functions are probably good, at least they match the constant pretty well.

[0xferit]

I changed the abbreviations according to https://www.princeton.edu/~maelabs/mae324/glos324/entropy.htm

[angularsen]

As far as I can tell, this looks good to go.

[angularsen]

Nice, @ferittuncer do you want to do the honors of releasing a new nuget?

[0xferit]

Sure @angularsen, 3.80.0 is on its way! :)

[angularsen]

Wohoo! :-)

[angularsen]

@ferittuncer I noticed you didn't push the git tag UnitsNet/3.80.0, so I've updated the wiki with a missing parameter git push --follow-tags that auto-pushes the tags when you push the code. I use a bash alias gpu='git push --follow-tags --set-upstream' that does this for me, so I forgot about it.

If you just want to push tags, and not code, you can run git push --tags.

If you could run either of these two commands to push the tag you have locally, that would be great!

[0xferit]

Thanks for information. I am going to do just as you described next time @angularsen. I see that you released 3.81.0 now, so do I have to take any action for now?

[angularsen]

Yes, please push tag 3.80.0 so that the repository has a tag for the release. I could create the tag, but then you and me/others would have different versions of the same tag.

git push --tags

The tags then show under Releases: https://github.com/angularsen/UnitsNet/releases

I also try to add the changes to the tag text, but I've not been strict about this and often forgot or didn't bother. The advantage is that the Releases page would list the changes per release. This can be edited from the github website too.

[0xferit]

@angularsen I did push the tags but it seems I pushed a wrong tag mistakenly too. Sorry, I'm not experienced with tags. What should we do about this? 7bdd0f0

This tag was created in my local repo when I mistakenly bumped JsonNet version, I dropped that commit but it seems the tag remained, so when I pushed all the tags, you know...

[angularsen]

No biggie, just delete the tag both locally and on remote.

git push --delete origin tagname   #remote 
git tag --delete tagname                #locally

The only thing is that if anyone else has pulled from the repo, they will also have the tag locally and if they are a collaborator they will re-push the same tag back up again. Git is a bit messy on these things.

[0xferit]

Yup, tags corrected. : )