Skip to content

Fix missing prefixes for localized abbreviations #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

DiSnider
Copy link
Contributor

$prefixIndex variable shouldn't be incremented while enumerating by $unit.Localization because in that case for second and for all the next cultures abbreviation will be taken from the subsequent prefix index that is wrong.

@angularsen angularsen changed the title fixed a bug with localized abbreviations with prefixes Fix missing prefixes for localized abbreviations (#297) Oct 12, 2017
@angularsen angularsen changed the title Fix missing prefixes for localized abbreviations (#297) Fix missing prefixes for localized abbreviations Oct 12, 2017
@angularsen angularsen merged commit be4bb55 into angularsen:master Oct 12, 2017
@angularsen
Copy link
Owner

Great, thanks!
Next time, it would be good if you could run generate-code.bat and push the regenerated code files too. No biggie, just helps get an overview of the complete changes. I did verify locally and will push to master separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants