[WIP] Automatic overload generator #275
Conversation
|
Nice! This looks exciting, I think I see where you are going with this. Some initial thoughts:
|
|
This is only for adding operator overloads. The existing JSON-files would need the new array and also a property that points out the base SI-unit when it isn't the base unit (most units that has the automatic milli, centi, deci etc.) Once I can generate the operator overloads from with the DLL my idea is to create a new Powershell script that calls the DLL and generates C# code with the operator overloads. The end result would be exactly what me and Ulf did manually more than a year ago for some of the units. The main advantage is that it would extend to all units and is less error prone. It also opens up the possibility to add more intermediate units in an easy way (such as m^-1 or s/m). But that is for the future. My main reason for doing this is that I really wanted to do it this way back when we did it manually, but I couldn't figure out how before I saw @phatcher's post (in #260) and understood how it could be done. With some clever work it might be possible to replace the |
|
Alright, I'll be watching this eagerly :-) |
|
@anjdreas and @aignas this doesn't build but the code generation works and it should show approximately where I'm going The PowerShell code will require heavy refactoring once the generated code looks good, learning PowerShell by doing this... |
| Assert.Equal(2,actualQuantities.Length); | ||
|
|
||
| Assert.Contains(speedQuantity.Name, actualQuantityNames); | ||
| Assert.Contains(timeQuantity.Name, actualQuantityNames); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void ShouldReturnLengthWhenGivenSpeed() |
There was a problem hiding this comment.
Test names confused me a bit, I think it would be easier to read if you include the method you are testing, such as GetMultiplicationOverloads_ReturnsLength_GivenSpeed.
Also just a tip, if you have many tests for GetMultiplicationOverloads, you can add a nested class named GetMultiplicationOverloads and put the test methods inside it so they don't have to include it in their name. At least with R# test runner, it becomes a hierarchy of tests and it's clear what tests belong where.
| @@ -22,6 +22,21 @@ public static int[] ElementwiseSubtract(this int[] left, int[] right) | |||
| return result; | |||
| } | |||
|
|
|||
| public static int[] ElementwiseAdd(this int[] left, int[] right) | |||
There was a problem hiding this comment.
You can use LINQ's .Zip(), like so
public static int[] ElementwiseAdd(this int[] left, int[] right)
{
return left.Zip(right, (l,r) => l + r).ToArray();
}
However, it just picks the shortest length of the two, so you may want to keep the length check.
| foreach (var multiplication in multiplications) | ||
| { | ||
| yield return multiplication; | ||
| yield return new Overload(multiplication.Result, multiplication.Right, multiplication.Left); |
There was a problem hiding this comment.
Is this an intended duplicate?
There was a problem hiding this comment.
It was intended, but is wrong. My thought was that multiplication is communicative, but the other multiplication will end up in the other type.
| @@ -78,5 +78,6 @@ | |||
| } | |||
| ] | |||
| } | |||
| ] | |||
| ], | |||
| "SiArray": [ 1, 0, -1, 0, 0, 0, 0 ] | |||
There was a problem hiding this comment.
I'm just trying to understand still, so you're adding the SI array to each quantity, which represents the base unit?
In the case of speed, it's m/s. And you use this to automatically generate all possible * and / operators across quantities, such as Length / Time = Speed.
Neat!
Thinking further, can we use this to
- Convert to other speed units? Use
FromBaseToUnitFuncor do we add anSiArrayto each unit?
There was a problem hiding this comment.
I'm considering creating the SI-arrays by parsing the unit names (or abbreviations), but I'm not sure if that is actually faster than just creating the arrays by hand.
It would be possible to create a similar double array with conversion factors for other unit systems (like Imperial). That could be used to automatically generate the code for conversion to that unit system. Since we already have Imperial for most quantities I'm not sure if it is really necessary. But it would be nice when adding new quantities.
|
I don't mean to nag, but curious if you plan to make progress on this? :-) |
|
I plan to continue but it has been too much at work lately so I haven't had time |
|
@eriove I'll close this PR to keep the issue list tidy, but please just reopen it whenever you pick it up again. |
As discussed in #260 here is a proof of concept where I generate operator overloads from a vector of SI quantity exponents.
Right now I'm adding the exponents in the tests but they would be in the JSON files once everything is complete.
Also have some issues with paths, new project formats and nCrunch to sort out before this builds out of the box (no GUI support for symbolic links)
Have not even started to think about the PowerShell scripts but I don't think that will be a problem.