Skip to content

Add density units #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2022
Merged

Add density units #1012

merged 1 commit into from
Jan 26, 2022

Conversation

devel0
Copy link
Contributor

@devel0 devel0 commented Jan 17, 2022

Add TonnesPerCubicFoot, TonnesPerCubicInch, GramsPerCubicFoot, GramsPerCubicInch, PoundsPerCubicMeter, PoundsPerCubicCentimeter, PoundsPerCubicMillimeter, SlugsPerCubicMeter, SlugsPerCubicCentimeter, SlugsPerCubicMillimeter, SlugsPerCubicInch density units

@devel0
Add TonnesPerCubicFoot, TonnesPerCubicInch, GramsPerCubicFoot, GramsP…
8f39863 
…erCubicInch, PoundsPerCubicMeter, PoundsPerCubicCentimeter, PoundsPerCubicMillimeter, SlugsPerCubicMeter, SlugsPerCubicCentimeter, SlugsPerCubicMillimeter, SlugsPerCubicInch density units
@angularsen
Copy link
Owner

Hi, will try to get to this shortly.

angularsen
angularsen approved these changes Jan 26, 2022
View reviewed changes
Copy link
Owner

@angularsen angularsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect to me 🙌

UnitsNet.Tests/CustomCode/DensityTests.cs
@@ -89,6 +89,28 @@ public class DensityTests : DensityTestsBase

protected override double KilogramsPerLiterInOneKilogramPerCubicMeter => 1e-3;

protected override double TonnesPerCubicFootInOneKilogramPerCubicMeter => 2.8316846591999996e-05;

protected override double TonnesPerCubicInchInOneKilogramPerCubicMeter => 1.6387063999999997e-08;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

UnitsNet.Tests/CustomCode/DensityTests.cs
@@ -89,6 +89,28 @@ public class DensityTests : DensityTestsBase

protected override double KilogramsPerLiterInOneKilogramPerCubicMeter => 1e-3;

protected override double TonnesPerCubicFootInOneKilogramPerCubicMeter => 2.8316846591999996e-05;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

UnitsNet.Tests/CustomCode/DensityTests.cs

protected override double TonnesPerCubicInchInOneKilogramPerCubicMeter => 1.6387063999999997e-08;

protected override double GramsPerCubicFootInOneKilogramPerCubicMeter => 28.316846591999994;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

UnitsNet.Tests/CustomCode/DensityTests.cs

protected override double GramsPerCubicFootInOneKilogramPerCubicMeter => 28.316846591999994;

protected override double GramsPerCubicInchInOneKilogramPerCubicMeter => 0.016387063999999996;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

UnitsNet.Tests/CustomCode/DensityTests.cs

protected override double GramsPerCubicInchInOneKilogramPerCubicMeter => 0.016387063999999996;

protected override double PoundsPerCubicMeterInOneKilogramPerCubicMeter => 2.204622621848775;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

UnitsNet.Tests/CustomCode/DensityTests.cs

protected override double PoundsPerCubicCentimeterInOneKilogramPerCubicMeter => 2.204622621848775e-6;

protected override double PoundsPerCubicMillimeterInOneKilogramPerCubicMeter => 2.204622621848775e-9;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

UnitsNet.Tests/CustomCode/DensityTests.cs

protected override double PoundsPerCubicMillimeterInOneKilogramPerCubicMeter => 2.204622621848775e-9;

protected override double SlugsPerCubicMeterInOneKilogramPerCubicMeter => 0.068521765561961;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

UnitsNet.Tests/CustomCode/DensityTests.cs

protected override double SlugsPerCubicMeterInOneKilogramPerCubicMeter => 0.068521765561961;

protected override double SlugsPerCubicCentimeterInOneKilogramPerCubicMeter => 6.8521765561961e-8;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

UnitsNet.Tests/CustomCode/DensityTests.cs

protected override double SlugsPerCubicCentimeterInOneKilogramPerCubicMeter => 6.8521765561961e-8;

protected override double SlugsPerCubicMillimeterInOneKilogramPerCubicMeter => 6.8521765561961e-11;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

UnitsNet.Tests/CustomCode/DensityTests.cs

protected override double SlugsPerCubicMillimeterInOneKilogramPerCubicMeter => 6.8521765561961e-11;

protected override double SlugsPerCubicInchInOneKilogramPerCubicMeter => 1.1228705576569e-6;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified

@angularsen angularsen merged commit 28f9dc8 into angularsen:master Jan 26, 2022
@angularsen
Copy link
Owner

Nuget should be out shortly
Release UnitsNet/4.115.0 · angularsen/UnitsNet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angularsen angularsen angularsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devel0 @angularsen