-
Notifications
You must be signed in to change notification settings - Fork 393
The flow unit SCCM is missing #713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, would you be willing to do a pull request on it? On the phone now, but
details are on the Readme page.
…On Tue, Oct 22, 2019, 15:19 bitbonk ***@***.***> wrote:
A very common unit used in mass flow controllers
<https://en.wikipedia.org/wiki/Mass_flow_controller> is SCCM
<https://en.wikipedia.org/wiki/SCCM_(flow_unit)> (aka. standard cubic
centimeters per minute). Unfortunately this unit is missing in UnitsNet.
You already have VolumeFlowUnit.CubicDecimeterPerMinute please also add
VolumeFlowUnit.CubicCentimeterPerMinute.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#713?email_source=notifications&email_token=AAGAK2ATK5GAVG6WB7OCOJTQP34WVA5CNFSM4JDPTAP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTP5FHA>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGAK2FXAWJ4J24OWRNOC73QP34WVANCNFSM4JDPTAPQ>
.
|
Yes, I would. Seems easy enough. |
After further investigation, the unit SCCM (standard cubic centimeters per minute) does not belong to same quantity type (VolumeFlow) with a unit like cm³/m. The wikipedia article suggests that SCCM is the flow rate under "standard conditions for temperature and pressure". So to convert one to the other the actual pressure and temperature seems to be needed. So the question is 1 How do we get an authoritative answer from a domain expert about what new unit to introduce? Some reference links: |
I'm no domain expert but here are my 5c on the subject:
The only problem here is the acceptance criteria for new (and obscure) Quantities - such as the proposed SFR - but that is not up to me to decide... However- the question that I expect would come next is "Wouldn't the existing VF quantity type work for you?". |
I am not familiar with this domain at all, but my intuition tells me @lipchev makes some good points here. It seems like maybe what you are looking for is a wrapper type that holds more information (temperature + pressure + flow rate) to represent flow rate at a certain temperature and pressure. Then you can convert to flow rates at other conditions of temperature or pressure. If you agree, then I think maybe this is out of scope of UnitsNet library and perhaps better placed per application. Or, if many others would find this concept useful, we could add it to the library. I'm open to suggestions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closing this in favor of #724 . |
A very common unit used in mass flow controllers is SCCM (aka. standard cubic centimeters per minute). Unfortunately this unit is missing in UnitsNet.
You already have
VolumeFlowUnit.CubicDecimeterPerMinute
please also addVolumeFlowUnit.CubicCentimeterPerMinute
.The text was updated successfully, but these errors were encountered: