Skip to content

Write JSON serialization tests against two versions of UnitsNet.Serialization.JsonNet #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
angularsen opened this issue Mar 18, 2018 · 2 comments

Comments

@angularsen
Copy link
Owner

angularsen commented Mar 18, 2018

To catch future breaking changes in UnitsNet, as seen in #416.

The json serialiation tests should run against two UnitsNet.Serialization.JsonNet dlls:

  • The UnitsNet.Serialization.JsonNet project, which is built and run in the tests
  • v1.3.0 or some other "old" version that currently works against latest UnitsNet, but may later stop working

I'm not exactly sure how, but it seems you can side-load two versions of a dll and call them separately:

https://stackoverflow.com/questions/42715564/using-2-different-versions-of-the-same-dll
https://devnet.kentico.com/articles/referencing-multiple-versions-of-the-same-assembly-in-a-single-application
https://docs.microsoft.com/en-us/dotnet/framework/configure-apps/file-schema/runtime/codebase-element

Alternatively, maybe simpler, is to have two test projects with the same test code and different references to UnitsNet.Serialization.JsonNet.

@gojanpaolo
Copy link
Contributor

I could try doing this :)

@angularsen
Copy link
Owner Author

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants