Skip to content

UnitsNet.Serialization v1.2.2 is not compatible with UnitsNet >= v3.92 #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gojanpaolo opened this issue Mar 15, 2018 · 6 comments
Closed

Comments

@gojanpaolo
Copy link
Contributor

@angularsen The current released UnitsNet.Serialization v1.2.2 is not compatible with UnitsNet v3.92 and up.
Releasing the latest build should fix the issue.

@angularsen
Copy link
Owner

Wat? Doh, of course!

#389

There should be no breaking changes in neither main lib nor JSON serialization.

I am a lying bastard, that's what happened :-)
All my tests were using the latest UnitsNet code, so I did not actually test with the old JSON code.
Oh well, I think I can live with this compromise instead of trying to make it truly backwards compatible - because that sounds really painful and maybe not even possible without reverting the whole thing.

@angularsen
Copy link
Owner

Json nuget 1.3.0 is out.

@gojanpaolo
Copy link
Contributor Author

Awesome! Thank you. closing this issue. :)

@gojanpaolo
Copy link
Contributor Author

I think it's fine even without backwards compatibility. But is it possible to also run the unit tests on the latest released version of both libraries? This would help catch this kind of issue early.

@angularsen
Copy link
Owner

Yes that's a good idea, the json tests could possibly run against two UnitsNet dlls. I'm not exactly sure how, but it seems you can side-load two versions of a dll and call them separately:

https://stackoverflow.com/questions/42715564/using-2-different-versions-of-the-same-dll
https://devnet.kentico.com/articles/referencing-multiple-versions-of-the-same-assembly-in-a-single-application
https://docs.microsoft.com/en-us/dotnet/framework/configure-apps/file-schema/runtime/codebase-element

@angularsen
Copy link
Owner

Created issue #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants