Fix msbuild warnings, re-enable and treat all as errors (#617)

* Remove <NoWarn> from projects

* Merge partial of BaseUnits

* R#: Add "Gullberg" to dictionary

* Obsolete Molarity.FromDensity()

* Add xmldoc to fix msbuild warnings

Mute some compiler warnings

* Treat compiler warning as error for all projects

Author: angularsen

UnitsNet.Serialization.JsonNet.CompatibilityTests/UnitsNet.Serialization.JsonNet.CompatibilityTests.csproj

@@ -4,6 +4,7 @@
     <TargetFrameworks>netcoreapp2.0</TargetFrameworks>
     <RootNamespace>UnitsNet.Serialization.JsonNet.CompatibilityTests</RootNamespace>
     <LangVersion>7.3</LangVersion>
+    <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

UnitsNet.Serialization.JsonNet.Tests/UnitsNet.Serialization.JsonNet.Tests.csproj

@@ -4,6 +4,7 @@
     <TargetFrameworks>netcoreapp2.0</TargetFrameworks>
     <RootNamespace>UnitsNet.Serialization.JsonNet.Tests</RootNamespace>
     <LangVersion>7.3</LangVersion>
+    <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>

UnitsNet.Serialization.JsonNet/UnitsNet.Serialization.JsonNet.csproj

@@ -20,9 +20,9 @@
   <PropertyGroup>
     <AssemblyVersion>4.0.0.0</AssemblyVersion> <!-- Should reflect major part of Version -->
     <LangVersion>7.3</LangVersion>
-    <NoWarn>CS1701;CS1702;CS1705;CS0618</NoWarn>
     <RootNamespace>UnitsNet.Serialization.JsonNet</RootNamespace>
     <TargetFrameworks>netstandard2.0;net40</TargetFrameworks>
+    <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
   </PropertyGroup>
 
   <!-- SourceLink -->

UnitsNet.Tests/CustomCode/MolarityTests.cs

@@ -42,7 +42,7 @@ public void ExpectDensityConvertedToMolarityCorrectly()
         {
             var density = Density.FromKilogramsPerCubicMeter(60.02);
             var mw = Mass.FromGrams(58.443);
-            var molarity = Molarity.FromDensity(density, mw).MolesPerCubicMeter;
+            var molarity = (density / mw).MolesPerCubicMeter;
             AssertEx.EqualTolerance(1026.98355, molarity, MolesPerCubicMeterTolerance);
         }
 

UnitsNet.Tests/QuantityInfoTest.cs

@@ -24,9 +24,12 @@ public void Constructor_AssignsProperties()
 
             Assert.Equal(expectedZero, info.Zero);
             Assert.Equal("Length", info.Name);
+            // Obsolete members
+#pragma warning disable 618
             Assert.Equal(expectedUnits, info.Units);
             Assert.Equal(expectedBaseUnit, info.BaseUnit);
             Assert.Equal(new[]{"Centimeter", "Kilometer"}, info.UnitNames);
+#pragma warning restore 618
             Assert.Equal(expectedQuantityType, info.QuantityType);
             Assert.Equal(expectedBaseDimensions, info.BaseDimensions);
         }
@@ -44,9 +47,12 @@ public void GenericsConstructor_AssignsProperties()
 
             Assert.Equal(expectedZero, info.Zero);
             Assert.Equal("Length", info.Name);
+            // Obsolete members
+#pragma warning disable 618
             Assert.Equal(expectedUnits, info.Units);
             Assert.Equal(expectedBaseUnit, info.BaseUnit);
             Assert.Equal(new[]{"Centimeter", "Kilometer"}, info.UnitNames);
+#pragma warning restore 618
             Assert.Equal(expectedQuantityType, info.QuantityType);
             Assert.Equal(expectedBaseDimensions, info.BaseDimensions);
         }

UnitsNet.Tests/QuantityTest.cs

@@ -52,10 +52,13 @@ public void GetInfo_GivenLength_ReturnsQuantityInfoForLength()
 
             Assert.Equal("Length", quantityInfo.Name);
             Assert.Equal(QuantityType.Length, quantityInfo.QuantityType);
+            // Obsolete members
+#pragma warning disable 618
             Assert.Superset(knownLengthUnitNames.ToHashSet(), quantityInfo.UnitNames.ToHashSet());
             Assert.Superset(knownLengthUnits.ToHashSet(), quantityInfo.Units.ToHashSet());
             Assert.Equal(lengthUnitCount, quantityInfo.UnitNames.Length);
             Assert.Equal(lengthUnitCount, quantityInfo.Units.Length);
+#pragma warning restore 618
             Assert.Equal(typeof(LengthUnit), quantityInfo.UnitType);
             Assert.Equal(typeof(Length), quantityInfo.ValueType);
             Assert.Equal(Length.Zero, quantityInfo.Zero);
@@ -72,10 +75,13 @@ public void GetInfo_GivenMass_ReturnsQuantityInfoForMass()
 
             Assert.Equal("Mass", quantityInfo.Name);
             Assert.Equal(QuantityType.Mass, quantityInfo.QuantityType);
+            // Obsolete members
+#pragma warning disable 618
             Assert.Superset(knownMassUnitNames.ToHashSet(), quantityInfo.UnitNames.ToHashSet());
             Assert.Superset(knownMassUnits.ToHashSet(), quantityInfo.Units.ToHashSet());
             Assert.Equal(massUnitCount, quantityInfo.UnitNames.Length);
             Assert.Equal(massUnitCount, quantityInfo.Units.Length);
+#pragma warning restore 618
             Assert.Equal(typeof(MassUnit), quantityInfo.UnitType);
             Assert.Equal(typeof(Mass), quantityInfo.ValueType);
             Assert.Equal(Mass.Zero, quantityInfo.Zero);

UnitsNet.Tests/QuantityTests.cs

@@ -40,13 +40,16 @@ private static void AssertQuantityInfoRepresentsLength(QuantityInfo<LengthUnit>
         {
             Assert.Equal(Length.Zero, quantityInfo.Zero);
             Assert.Equal("Length", quantityInfo.Name);
-
-            var lengthUnits = EnumUtils.GetEnumValues<LengthUnit>().Except(new[] {LengthUnit.Undefined}).ToArray();
-            Assert.Equal(lengthUnits, quantityInfo.Units);
             Assert.Equal(QuantityType.Length, quantityInfo.QuantityType);
 
+            var lengthUnits = EnumUtils.GetEnumValues<LengthUnit>().Except(new[] {LengthUnit.Undefined}).ToArray();
             var lengthUnitNames = lengthUnits.Select(x => x.ToString());
+
+            // Obsolete members
+#pragma warning disable 618
+            Assert.Equal(lengthUnits, quantityInfo.Units);
             Assert.Equal(lengthUnitNames, quantityInfo.UnitNames);
+#pragma warning restore 618
         }
     }
 }

UnitsNet.Tests/UnitsNet.Tests.csproj

@@ -3,8 +3,8 @@
   <PropertyGroup>
     <TargetFrameworks>netcoreapp2.0</TargetFrameworks>
     <RootNamespace>UnitsNet.Tests</RootNamespace>
-    <NoWarn>CS1701;CS1702;CS1705;CS0618</NoWarn>
     <LangVersion>7.3</LangVersion>
+    <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
@@ -25,4 +25,4 @@
     <ProjectReference Include="..\UnitsNet\UnitsNet.csproj" />
   </ItemGroup>
 
-</Project>
+</Project>

UnitsNet.WindowsRuntimeComponent/UnitsNet.WindowsRuntimeComponent.csproj

@@ -18,7 +18,6 @@
     <ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
     <AllowCrossPlatformRetargeting>false</AllowCrossPlatformRetargeting>
     <OutputPath>..\Artifacts\UnitsNet.WindowsRuntimeComponent</OutputPath>
-    <NoWarn>CS1701;CS1702;CS1705;CS0618;CS0809;CS1591</NoWarn>
     <LangVersion>7.3</LangVersion>
 
     <!-- SourceLink -->
@@ -135,4 +134,4 @@
   <Target Name="AfterBuild">
   </Target>
   -->
-</Project>
+</Project>

UnitsNet.sln.DotSettings

@@ -16,4 +16,5 @@
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EAddAccessorOwnerDeclarationBracesMigration/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002ECSharpPlaceAttributeOnSameLineMigration/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateBlankLinesAroundFieldToBlankLinesAroundProperty/@EntryIndexedValue">True</s:Boolean>
-	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateThisQualifierSettings/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>
+	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateThisQualifierSettings/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=Gullberg/@EntryIndexedValue">True</s:Boolean></wpf:ResourceDictionary>