This repository was archived by the owner on Sep 16, 2022. It is now read-only.
refactor(Compiler): Try removing all computeNode() calls. #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
reviewed
Jul 8, 2018
| @@ -12,7 +12,6 @@ import 'package:angular/src/core/linker/app_view.dart'; | |||
| import 'change_detection.dart' as _user; | |||
|
|
|||
| // Required for "type inference" (scoping). | |||
There was a problem hiding this comment.
Call this comment be removed as well?
matanlurey
added a commit
that referenced
this pull request
Jul 11, 2018
This API would not be supported in the "new" analyzer/build APIs IIRC. Closes #1469 PiperOrigin-RevId: 204152365
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #801.
It's likely this one will need significant testing internally.